You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kristian Marinkovic (JIRA)" <de...@tapestry.apache.org> on 2007/06/12 14:17:26 UTC
[jira] Created: (TAPESTRY-1562) PageLoaderProcessor handles
embeddedComponentIds case-sensitive -> should be case-insensitive
PageLoaderProcessor handles embeddedComponentIds case-sensitive -> should be case-insensitive
---------------------------------------------------------------------------------------------
Key: TAPESTRY-1562
URL: https://issues.apache.org/jira/browse/TAPESTRY-1562
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.5
Reporter: Kristian Marinkovic
Priority: Minor
The PageLoaderProcessor does not handle embedded componentIds as case insensitive.
Therefore logging the error message "embeddedComponentsNotInTemplate".
(Please see commented source snippet)
private void loadTemplateForComponent(ComponentPageElement loadingElement) {
...
// TODO: should make embedded ids eg. lowercase
Set<String> embeddedIds = CollectionFactory.newSet(_loadingComponentModel
.getEmbeddedComponentIds());
_idAllocator.clear();
for (String id : template.getComponentIds())
{
_idAllocator.allocateId(id);
// TODO: should make id lowercase before remove
embeddedIds.remove(id);
}
// TODO: because the set is case-sensitive this messages gets logged if the component
// id is written in different cases in template and java class
if (!embeddedIds.isEmpty())
log.error(ServicesMessages.embeddedComponentsNotInTemplate(
embeddedIds,
componentClassName));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1562) Spurious warnings about missing
component ids due to case-sensitive checking of template ids vs. declared
components
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1562:
-------------------------------------------
Summary: Spurious warnings about missing component ids due to case-sensitive checking of template ids vs. declared components (was: PageLoaderProcessor handles embeddedComponentIds case-sensitive -> should be case-insensitive)
> Spurious warnings about missing component ids due to case-sensitive checking of template ids vs. declared components
> --------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1562
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1562
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Kristian Marinkovic
> Priority: Minor
>
> The PageLoaderProcessor does not handle embedded componentIds as case insensitive.
> Therefore logging the error message "embeddedComponentsNotInTemplate".
> (Please see commented source snippet)
> private void loadTemplateForComponent(ComponentPageElement loadingElement) {
> ...
> // TODO: should make embedded ids eg. lowercase
> Set<String> embeddedIds = CollectionFactory.newSet(_loadingComponentModel
> .getEmbeddedComponentIds());
> _idAllocator.clear();
> for (String id : template.getComponentIds())
> {
> _idAllocator.allocateId(id);
> // TODO: should make id lowercase before remove
> embeddedIds.remove(id);
> }
> // TODO: because the set is case-sensitive this messages gets logged if the component
> // id is written in different cases in template and java class
> if (!embeddedIds.isEmpty())
> log.error(ServicesMessages.embeddedComponentsNotInTemplate(
> embeddedIds,
> componentClassName));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1562) Spurious warnings about missing
component ids due to case-sensitive checking of template ids vs. declared
components
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1562.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.5
Assignee: Howard M. Lewis Ship
> Spurious warnings about missing component ids due to case-sensitive checking of template ids vs. declared components
> --------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1562
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1562
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: Kristian Marinkovic
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.0.5
>
>
> The PageLoaderProcessor does not handle embedded componentIds as case insensitive.
> Therefore logging the error message "embeddedComponentsNotInTemplate".
> (Please see commented source snippet)
> private void loadTemplateForComponent(ComponentPageElement loadingElement) {
> ...
> // TODO: should make embedded ids eg. lowercase
> Set<String> embeddedIds = CollectionFactory.newSet(_loadingComponentModel
> .getEmbeddedComponentIds());
> _idAllocator.clear();
> for (String id : template.getComponentIds())
> {
> _idAllocator.allocateId(id);
> // TODO: should make id lowercase before remove
> embeddedIds.remove(id);
> }
> // TODO: because the set is case-sensitive this messages gets logged if the component
> // id is written in different cases in template and java class
> if (!embeddedIds.isEmpty())
> log.error(ServicesMessages.embeddedComponentsNotInTemplate(
> embeddedIds,
> componentClassName));
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org