You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/09 14:20:34 UTC

[GitHub] [superset] kgabryje opened a new pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

kgabryje opened a new pull request #15063:
URL: https://github.com/apache/superset/pull/15063


   ### SUMMARY
   This PR changes the behaviour of hiding native filters out of scope, which was originally implemented in https://github.com/apache/superset/pull/14933.
   Before, we considered filters to be "in scope" if they were placed in the last clicked tab. This approach presented several issues. The most significant issue was that in case of dashboards without top level tabs, there was no way to have charts unattached to any tab to be considered in scope once some row level tab had been clicked (as the scope was set only by clicking tabs).
   The new proposal, implemented in this PR, is that we consider all visible charts to be "in scope". That means that in order to determine if a filter is in scope, we no longer check only the last clicked tab, but the whole tabs tree of the dashboard. For details, see attached recordings of the new native filters behaviour presented on dashboards with (the first video) and without (second video) top level tabs
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: see https://github.com/apache/superset/pull/14933
   After:
   https://user-images.githubusercontent.com/15073128/121371437-d6de1a00-c93d-11eb-9776-5ba53f35ab33.mov
   https://user-images.githubusercontent.com/15073128/121371703-0ab93f80-c93e-11eb-8b92-3d216a049450.mov
   
   ### TESTING INSTRUCTIONS
   0. Set `DASHBOARD_NATIVE_FILTERS` feature flag to `True`
   1. Create dashboards with tabs (top level and/or row level)
   2. Add some native filters, go crazy with their scopes
   3. Verify that filters that don't have any visible charts in scope are moved to "Out of scope" panel
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc @villebro @michael-s-molina 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] suddjian commented on a change in pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #15063:
URL: https://github.com/apache/superset/pull/15063#discussion_r648761375



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -80,11 +80,31 @@ const FilterControls: FC<FilterControlsProps> = ({
     element => element.type === TAB_TYPE,
   );
   const showCollapsePanel = dashboardHasTabs && cascadeFilters.length > 0;
-  if (!lastFocusedTabId || !dashboardHasTabs) {
+
+  // we check native filters scopes only on dashboards with tabs
+  if (!dashboardHasTabs) {
     filtersInScope = cascadeFilters;
   } else {
     cascadeFilters.forEach((filter, index) => {
-      if (cascadeFilters[index].tabsInScope?.includes(lastFocusedTabId)) {
+      // Filter is in scope if any of it's charts is visible.
+      // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
+      // Chart is in an active tab tree if all of it's ancestors of type TAB are active
+      const isFilterInScope = cascadeFilters[index].chartsInScope?.some(

Review comment:
       ```suggestion
         const isFilterInScope = filter.chartsInScope?.some(
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje merged pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #15063:
URL: https://github.com/apache/superset/pull/15063


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-858812022


   @kgabryje Ephemeral environment spinning up at http://54.203.224.120:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-859473196


   # [Codecov](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#15063](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85ebda2) into [master](https://codecov.io/gh/apache/superset/commit/3456dd571ca705699766473e55ededd36c6f4dc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3456dd5) will **decrease** coverage by `0.00%`.
   > The diff coverage is `66.03%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/15063/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #15063      +/-   ##
   ==========================================
   - Coverage   77.54%   77.53%   -0.01%     
   ==========================================
     Files         967      967              
     Lines       49759    49787      +28     
     Branches     6352     6358       +6     
   ==========================================
   + Hits        38585    38602      +17     
   - Misses      10972    10983      +11     
     Partials      202      202              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.43% <66.03%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.72% <ø> (ø)` | |
   | [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.30% <ø> (ø)` | |
   | [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `73.33% <0.00%> (ø)` | |
   | [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `28.65% <33.33%> (ø)` | |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `75.00% <64.10%> (-25.00%)` | :arrow_down: |
   | [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `86.79% <85.71%> (-0.71%)` | :arrow_down: |
   | [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/15063/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `80.00% <100.00%> (+2.41%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3456dd5...85ebda2](https://codecov.io/gh/apache/superset/pull/15063?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-859536649


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on a change in pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #15063:
URL: https://github.com/apache/superset/pull/15063#discussion_r649851737



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -80,11 +80,31 @@ const FilterControls: FC<FilterControlsProps> = ({
     element => element.type === TAB_TYPE,
   );
   const showCollapsePanel = dashboardHasTabs && cascadeFilters.length > 0;
-  if (!lastFocusedTabId || !dashboardHasTabs) {
+
+  // we check native filters scopes only on dashboards with tabs
+  if (!dashboardHasTabs) {
     filtersInScope = cascadeFilters;
   } else {
     cascadeFilters.forEach((filter, index) => {
-      if (cascadeFilters[index].tabsInScope?.includes(lastFocusedTabId)) {
+      // Filter is in scope if any of it's charts is visible.
+      // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
+      // Chart is in an active tab tree if all of it's ancestors of type TAB are active
+      const isFilterInScope = cascadeFilters[index].chartsInScope?.some(

Review comment:
       Riiiight 🤦 Done

##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -80,11 +80,31 @@ const FilterControls: FC<FilterControlsProps> = ({
     element => element.type === TAB_TYPE,
   );
   const showCollapsePanel = dashboardHasTabs && cascadeFilters.length > 0;
-  if (!lastFocusedTabId || !dashboardHasTabs) {
+
+  // we check native filters scopes only on dashboards with tabs
+  if (!dashboardHasTabs) {
     filtersInScope = cascadeFilters;
   } else {
     cascadeFilters.forEach((filter, index) => {
-      if (cascadeFilters[index].tabsInScope?.includes(lastFocusedTabId)) {
+      // Filter is in scope if any of it's charts is visible.
+      // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
+      // Chart is in an active tab tree if all of it's ancestors of type TAB are active
+      const isFilterInScope = cascadeFilters[index].chartsInScope?.some(
+        chartId => {
+          const chartLayoutItem = Object.values(dashboardLayout).find(
+            layoutItem => layoutItem.meta?.chartId === chartId,
+          );
+          const tabParents = chartLayoutItem?.parents.filter(
+            (parent: string) => dashboardLayout[parent].type === TAB_TYPE,
+          );
+          return (

Review comment:
       I split some of that logic and moved it to `superset/superset-frontend/src/dashboard/components/nativeFilters/state.ts`

##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -80,11 +80,31 @@ const FilterControls: FC<FilterControlsProps> = ({
     element => element.type === TAB_TYPE,
   );
   const showCollapsePanel = dashboardHasTabs && cascadeFilters.length > 0;
-  if (!lastFocusedTabId || !dashboardHasTabs) {
+
+  // we check native filters scopes only on dashboards with tabs
+  if (!dashboardHasTabs) {
     filtersInScope = cascadeFilters;
   } else {
     cascadeFilters.forEach((filter, index) => {
-      if (cascadeFilters[index].tabsInScope?.includes(lastFocusedTabId)) {
+      // Filter is in scope if any of it's charts is visible.
+      // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
+      // Chart is in an active tab tree if all of it's ancestors of type TAB are active
+      const isFilterInScope = cascadeFilters[index].chartsInScope?.some(
+        chartId => {
+          const chartLayoutItem = Object.values(dashboardLayout).find(
+            layoutItem => layoutItem.meta?.chartId === chartId,
+          );
+          const tabParents = chartLayoutItem?.parents.filter(
+            (parent: string) => dashboardLayout[parent].type === TAB_TYPE,
+          );
+          return (

Review comment:
       I split some of that logic and moved it to `superset/superset-frontend/src/dashboard/components/nativeFilters/state.ts`, but I'm not sure if that's exactly what you expected. Can you take another look?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-858769000


   /testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=True


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-858050003


   /testenv up DASHBOARD_NATIVE_FILTERS = True


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] suddjian commented on a change in pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #15063:
URL: https://github.com/apache/superset/pull/15063#discussion_r649340166



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -80,11 +80,31 @@ const FilterControls: FC<FilterControlsProps> = ({
     element => element.type === TAB_TYPE,
   );
   const showCollapsePanel = dashboardHasTabs && cascadeFilters.length > 0;
-  if (!lastFocusedTabId || !dashboardHasTabs) {
+
+  // we check native filters scopes only on dashboards with tabs
+  if (!dashboardHasTabs) {
     filtersInScope = cascadeFilters;
   } else {
     cascadeFilters.forEach((filter, index) => {
-      if (cascadeFilters[index].tabsInScope?.includes(lastFocusedTabId)) {
+      // Filter is in scope if any of it's charts is visible.
+      // Chart is visible if it's placed in an active tab tree or if it's not attached to any tab.
+      // Chart is in an active tab tree if all of it's ancestors of type TAB are active
+      const isFilterInScope = cascadeFilters[index].chartsInScope?.some(
+        chartId => {
+          const chartLayoutItem = Object.values(dashboardLayout).find(
+            layoutItem => layoutItem.meta?.chartId === chartId,
+          );
+          const tabParents = chartLayoutItem?.parents.filter(
+            (parent: string) => dashboardLayout[parent].type === TAB_TYPE,
+          );
+          return (

Review comment:
       I'd love to see this logic moved out of components into a library of redux selectors, such as `selectActiveTabbedCharts()`, `selectFiltersInScope()`, `selectChartsInScopeByFilter()` etc. That way the state logic will be in a central location and easier to manage.
   
   It will also allow calculations to be memoized between different components. This is a triple-nested loop, which could become nasty on a dashboard with a lot of charts, tabs, and filters with significant numbers of charts in scope. And I know similar loops are running elsewhere in the app.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] kgabryje closed pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #15063:
URL: https://github.com/apache/superset/pull/15063


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #15063: feat(native-filters): Hide filters which don't affect any visible charts

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15063:
URL: https://github.com/apache/superset/pull/15063#issuecomment-858091582


   @junlincc Ephemeral environment spinning up at http://34.213.155.134:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org