You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/07/06 10:40:35 UTC
[GitHub] [spark] itholic opened a new pull request, #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
itholic opened a new pull request, #41877:
URL: https://github.com/apache/spark/pull/41877
### What changes were proposed in this pull request?
This PR proposes to enable `resample` on Spark Connect.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To increase pandas API coverage on Spark Connect
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
`resample` is available on Spark Connect.
### How was this patch tested?
Uncommented skipping tests, the existing CI should pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #41877:
URL: https://github.com/apache/spark/pull/41877#issuecomment-1624455071
cc @zhengruifeng Could you review this PR when you find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #41877:
URL: https://github.com/apache/spark/pull/41877#discussion_r1286739868
##########
python/pyspark/pandas/resample.py:
##########
@@ -131,8 +134,27 @@ def _resamplekey_scol(self) -> Column:
def _agg_columns_scols(self) -> List[Column]:
return [s.spark.column for s in self._agg_columns]
+ def get_make_interval( # type: ignore[return]
+ self, unit: str, col: Union[Column, int, float]
+ ) -> Column:
+ if is_remote():
+ from pyspark.sql.connect.functions import lit, make_interval
+
+ col = col if not isinstance(col, (int, float)) else lit(col) # type: ignore[assignment]
+ if unit == "MONTH":
+ return make_interval(months=col) # type: ignore
+ if unit == "HOUR":
+ return make_interval(hours=col) # type: ignore
+ if unit == "MINUTE":
+ return make_interval(mins=col) # type: ignore
+ if unit == "SECOND":
+ return make_interval(secs=col) # type: ignore
+ else:
+ sql_utils = SparkContext._active_spark_context._jvm.PythonSQLUtils
Review Comment:
@itholic can we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
URL: https://github.com/apache/spark/pull/41877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #41877:
URL: https://github.com/apache/spark/pull/41877#discussion_r1287813793
##########
python/pyspark/pandas/resample.py:
##########
@@ -131,8 +134,27 @@ def _resamplekey_scol(self) -> Column:
def _agg_columns_scols(self) -> List[Column]:
return [s.spark.column for s in self._agg_columns]
+ def get_make_interval( # type: ignore[return]
+ self, unit: str, col: Union[Column, int, float]
+ ) -> Column:
+ if is_remote():
+ from pyspark.sql.connect.functions import lit, make_interval
+
+ col = col if not isinstance(col, (int, float)) else lit(col) # type: ignore[assignment]
+ if unit == "MONTH":
+ return make_interval(months=col) # type: ignore
+ if unit == "HOUR":
+ return make_interval(hours=col) # type: ignore
+ if unit == "MINUTE":
+ return make_interval(mins=col) # type: ignore
+ if unit == "SECOND":
+ return make_interval(secs=col) # type: ignore
+ else:
+ sql_utils = SparkContext._active_spark_context._jvm.PythonSQLUtils
Review Comment:
Let me check & create a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #41877: [SPARK-43660][CONNECT][PS] Enable `resample` with Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #41877:
URL: https://github.com/apache/spark/pull/41877#issuecomment-1624550441
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org