You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/05/09 11:26:03 UTC

Review Request 21260: CLOUDSTACK-6620: [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21260/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-6620
    https://issues.apache.org/jira/browse/CLOUDSTACK-6620


Repository: cloudstack-git


Description
-------

[Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats. As hyperv agent tries to get the stats of non-existent vm


Diffs
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 7dbb8c1 

Diff: https://reviews.apache.org/r/21260/diff/


Testing
-------

Created the needed environment. Verified that after application of patch there was no nullpointerexception


Thanks,

Anshul Gangwar


Re: Review Request 21260: CLOUDSTACK-6620: [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21260/#review42565
-----------------------------------------------------------


Commit b82e26253c9f13c215558f78d8f1eab7cf8f9eb9 in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b82e262 ]

CLOUDSTACK-6620: Fixed null pointer exception in hyperv agent in getting vmstats, when all vms are deleted from outside


- ASF Subversion and Git Services


On May 9, 2014, 9:26 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21260/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 9:26 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6620
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6620
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats. As hyperv agent tries to get the stats of non-existent vm
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 7dbb8c1 
> 
> Diff: https://reviews.apache.org/r/21260/diff/
> 
> 
> Testing
> -------
> 
> Created the needed environment. Verified that after application of patch there was no nullpointerexception
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 21260: CLOUDSTACK-6620: [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21260/#review42563
-----------------------------------------------------------


Commit 4106aa07214209631ab9e6223c7efe4580ac30bf in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4106aa0 ]

CLOUDSTACK-6620: Fixed null pointer exception in hyperv agent in getting vmstats, when all vms are deleted from outside


- ASF Subversion and Git Services


On May 9, 2014, 9:26 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21260/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 9:26 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6620
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6620
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats. As hyperv agent tries to get the stats of non-existent vm
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 7dbb8c1 
> 
> Diff: https://reviews.apache.org/r/21260/diff/
> 
> 
> Testing
> -------
> 
> Created the needed environment. Verified that after application of patch there was no nullpointerexception
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Re: Review Request 21260: CLOUDSTACK-6620: [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21260/#review42568
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On May 9, 2014, 9:26 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21260/
> -----------------------------------------------------------
> 
> (Updated May 9, 2014, 9:26 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6620
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6620
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> [Hyper-v] when all vms on host are deleted from outside, then there is null pointer exception in hyperv agent in getting vmstats. As hyperv agent tries to get the stats of non-existent vm
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 7dbb8c1 
> 
> Diff: https://reviews.apache.org/r/21260/diff/
> 
> 
> Testing
> -------
> 
> Created the needed environment. Verified that after application of patch there was no nullpointerexception
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>