You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "driazati (via GitHub)" <gi...@apache.org> on 2023/04/24 19:36:04 UTC
[GitHub] [tvm] driazati opened a new pull request, #14715: [ci] Disable merge to main
driazati opened a new pull request, #14715:
URL: https://github.com/apache/tvm/pull/14715
This disables the merge to main behavior for this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ysh329 commented on pull request #14715: [cherry-pick][ARITH] Enhance CanonicalSimplify to Simplify ProdDiv and [ci] disable merge
Posted by "ysh329 (via GitHub)" <gi...@apache.org>.
ysh329 commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1525723215
> > > @ysh329 I believe this PR is exposing a latent bug that was being hidden by the merge before, I think we can fix it by cherry picking #14538, that works locally for me at least
> >
> >
> > Fixed with cherry-picked PR #14725. It's a bit strange why the previous PR CI test did not reflect this failed test.
>
> I think because before it was merging the PR from main, so the fix was being applied even though it hadn't been cherry-picked. To avoid the failure in your cherry-pick PR I just added both changes to this one
Great! Thanks for your work. 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ysh329 commented on pull request #14715: [ci] Disable merge to main
Posted by "ysh329 (via GitHub)" <gi...@apache.org>.
ysh329 commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1521161372
Hi @driazati , I tried this test locally and failed log as below:
```shell
$ python3 ./tests/python/unittest/test_arith_canonical_simplify.py
Traceback (most recent call last):
File "./tests/python/unittest/test_arith_canonical_simplify.py", line 427, in <module>
test_proddiv_simplify()
File "./tests/python/unittest/test_arith_canonical_simplify.py", line 398, in test_proddiv_simplify
ck.verify(flm(x * 32 * x, x), 0)
File "./tests/python/unittest/test_arith_canonical_simplify.py", line 29, in verify
assert tvm.ir.structural_equal(res, expected), "\ndata={}\nres={}\nexpected={}".format(
AssertionError:
data=x * 32 * x % x
res=x * 32 * x % x
expected=0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #14715: [cherry-pick][ARITH] Enhance CanonicalSimplify to Simplify ProdDiv and [ci] disable merge
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati merged PR #14715:
URL: https://github.com/apache/tvm/pull/14715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #14715: [ci] Disable merge to main
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1522533241
@ysh329 I believe this PR is exposing a latent bug that was being hidden by the merge before, I think we can fix it by cherry picking #14538, that works locally for me at least
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ysh329 commented on pull request #14715: [ci] Disable merge to main
Posted by "ysh329 (via GitHub)" <gi...@apache.org>.
ysh329 commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1523574959
> @ysh329 I believe this PR is exposing a latent bug that was being hidden by the merge before, I think we can fix it by cherry picking #14538, that works locally for me at least
Fixed with cherry-picked PR https://github.com/apache/tvm/pull/14725. It's a bit strange why the previous PR CI test did not reflect this failed test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #14715: [cherry-pick][ARITH] Enhance CanonicalSimplify to Simplify ProdDiv and [ci] disable merge
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1523789490
> > @ysh329 I believe this PR is exposing a latent bug that was being hidden by the merge before, I think we can fix it by cherry picking #14538, that works locally for me at least
>
> Fixed with cherry-picked PR #14725. It's a bit strange why the previous PR CI test did not reflect this failed test.
I think because before it was merging the PR from main, so the fix was being applied even though it hadn't been cherry-picked. To avoid the failure in your cherry-pick PR I just added both changes to this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14715: [ci] Disable merge to main
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1520721296
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @Mousius, @areusch, @gigiblender, @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ysh329 commented on pull request #14715: [ci] Disable merge to main
Posted by "ysh329 (via GitHub)" <gi...@apache.org>.
ysh329 commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1521056347
I found there's a test failed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #14715: [ci] Disable merge to main
Posted by "driazati (via GitHub)" <gi...@apache.org>.
driazati commented on PR #14715:
URL: https://github.com/apache/tvm/pull/14715#issuecomment-1521152318
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org