You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by superdecimal <gi...@git.apache.org> on 2015/05/20 18:02:21 UTC
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
GitHub user superdecimal opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37
Add CaptureVideoOption for quality
This adds quality CaptureVideoOption for Android. 0 is low 1 is high.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/superdecimal/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit f8740045fe9337c1fd3df9adcf7df950b400860f
Author: Paris Goudas <de...@darkstar.gr>
Date: 2015-05-20T15:53:30Z
Add CaptureVideoOption for quality
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by bgrayburn <gi...@git.apache.org>.
Github user bgrayburn commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-117840771
+1, since the non existent supported*Modes don't work
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by bgrayburn <gi...@git.apache.org>.
Github user bgrayburn commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128130243
Sorry not sure how you wanted me to document this, is this still necessary
since it's been merged?
On Wed, Aug 5, 2015, 15:36 asfgit <no...@github.com> wrote:
> Merged #37
> <https://github.com/apache/cordova-plugin-media-capture/pull/37>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-media-capture/pull/37#event-374582691>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128113487
It's non-standard, but it looks like it is required.
Can @bgrayburn document it as a quirk in Android and I'll merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128116412
I created a jira ticket for the missing supported*Modes functionality.
https://issues.apache.org/jira/browse/CB-9460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128143793
Like this -> #40
I got it! ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by bgrayburn <gi...@git.apache.org>.
Github user bgrayburn commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128144054
Thanks! Sorry, I appreciate the quick response!
On Wed, Aug 5, 2015, 16:50 Jesse MacFadyen <no...@github.com> wrote:
> Like this -> #40
> <https://github.com/apache/cordova-plugin-media-capture/pull/40>
> I got it! ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128143793>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Add CaptureVideoOption ...
Posted by bgrayburn <gi...@git.apache.org>.
Github user bgrayburn commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37#issuecomment-128098095
can someone who maintains this please comment or give an indication of why this hasn't been merged? This feature is critical to me for adoption of this plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org