You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by lifepuzzlefun <wj...@163.com> on 2023/05/11 16:00:57 UTC
[DISCUSS] PIP-270 Add config to set metadata size threshold for compression.
Dear Pulsar community,
I create a pip aim to add configuration on size based metadata compresssion.
https://github.com/apache/pulsar/issues/20307
We welcome your feedback and suggestions on this proposal.
RE: Re: [VOTE] PIP-270 Add config to set metadata size threshold for compression
Posted by lifepuzzlefun <wj...@163.com>.
Nice suggestion. I have change those parameters in the pip. It looks better now.
On 2023/05/15 13:21:06 PengHui Li wrote:
> It looks good to me.
>
> Just a minor suggestion about the name of the configuration.
>
> managedLedgerInfoCompressionSizeThreshold ->
> managedLedgerInfoCompressionThresholdInBytes
> managedCursorInfoCompressionSizeThreshold
> -> managedCursorInfoCompressionThresholdInBytes
>
> And is it better to introduce a minimum available value like 16KB
> to avoid mistakes from the user? I don't think the compaction will
> help much when the data is lower than 16KB.
>
> Thanks,
> Penghui
sorry, i will start the vote after the pip thoroughly discussed next time.
> Hello lifepuzzlefun,
> thanks for your proposal
> I believe that it is too early to start a VOTE as the discussion has
> not happened yet.
yeah i will follow the community way to do it.
but i think we need an agreement on this.
there are two point on this:
1. the configuration is public api so any update to public api should be discussed.
2. make a fist way for those small pr that just configuration.
> Side note: this change is small and it doesn't introduce breaking API
> changes, I am not sure that we need a PIP for it.
Re: [DISCUSS] PIP-270 Add config to set metadata size threshold for compression.
Posted by Asaf Mesika <as...@gmail.com>.
Hi,
I have a couple of questions:
current we support to set compression on ManagedLedger and ManagedCursor
> metadata
> by managedLedgerInfoCompressionType and managedCursorInfoCompressionType
Can you please elaborate what is the metadata of ManagedLedger and
ManagedCursor?
Where is that metadata saved to?
Can you elaborate the managed ledger role in short - it's the underlying
object for topics right?
I would be grateful if you can expand the PIP, so the reader will have
answers to those questions when reading it.
On Thu, May 11, 2023 at 7:28 PM Enrico Olivelli <eo...@gmail.com> wrote:
> Makes sense to me.
> Thanks for your contribution
>
> Enrico
>
> Il giorno gio 11 mag 2023 alle ore 18:01 lifepuzzlefun
> <wj...@163.com> ha scritto:
> >
> > Dear Pulsar community,
> >
> >
> > I create a pip aim to add configuration on size based metadata
> compresssion.
> >
> >
> > https://github.com/apache/pulsar/issues/20307
> >
> >
> > We welcome your feedback and suggestions on this proposal.
> >
>
Re: [DISCUSS] PIP-270 Add config to set metadata size threshold for compression.
Posted by Enrico Olivelli <eo...@gmail.com>.
Makes sense to me.
Thanks for your contribution
Enrico
Il giorno gio 11 mag 2023 alle ore 18:01 lifepuzzlefun
<wj...@163.com> ha scritto:
>
> Dear Pulsar community,
>
>
> I create a pip aim to add configuration on size based metadata compresssion.
>
>
> https://github.com/apache/pulsar/issues/20307
>
>
> We welcome your feedback and suggestions on this proposal.
>