You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/08 09:51:33 UTC
[GitHub] [superset] Yahyakiani commented on a change in pull request #17649: fix(Mixed Timeseries Chart): Custom Metric Label
Yahyakiani commented on a change in pull request #17649:
URL: https://github.com/apache/superset/pull/17649#discussion_r764707327
##########
File path: superset-frontend/packages/superset-ui-core/src/query/types/QueryFormData.ts
##########
@@ -146,7 +147,7 @@ export type ExtraFormData = ExtraFormDataAppend & ExtraFormDataOverride;
export interface BaseFormData extends TimeRange, FormDataResidual {
/** datasource identifier ${id}_${type} */
- datasource: string;
+ datasource: Datasource;
Review comment:
Thanks @villebro. Found the issue and was successfully able to resolve it.
Did the following:
1. Reverted the Type change and applied the fix
3. Ran Lint on the `superset-frontend` folder
4. Retested the UI after changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org