You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by suyogbarve <gi...@git.apache.org> on 2017/03/02 22:58:50 UTC
[GitHub] tomee pull request #60: amq and ibm mq portability using tomee
GitHub user suyogbarve opened a pull request:
https://github.com/apache/tomee/pull/60
amq and ibm mq portability using tomee
amq and ibm mq portability using tomee
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suyogbarve/tomee master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomee/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 64a5f64106cccb3feb68f7155650e603671662df
Author: Suyog Barve <su...@gmail.com>
Date: 2017-03-02T22:56:05Z
amq and imp portability using tome
amq and imp portability using tome
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tomee issue #60: amq and ibm mq portability using tomee
Posted by jgallimore <gi...@git.apache.org>.
Github user jgallimore commented on the issue:
https://github.com/apache/tomee/pull/60
Yes, I'll get that done today. Thanks for the nudge.
---
[GitHub] tomee issue #60: amq and ibm mq portability using tomee
Posted by radcortez <gi...@git.apache.org>.
Github user radcortez commented on the issue:
https://github.com/apache/tomee/pull/60
@jgallimore I know you were working on this some time ago. can you review it?
---
[GitHub] tomee issue #60: amq and ibm mq portability using tomee
Posted by jgallimore <gi...@git.apache.org>.
Github user jgallimore commented on the issue:
https://github.com/apache/tomee/pull/60
@suyogbarve Thank you for putting this together, it looks great. I have a couple of points for feedback:
* Can you add the ASL header to your source files?
* Can ChatBean and ChatBeanTest be removed?
* Update Java version to 1.8 in pom.xml for maven-compiler-plugin
* Remove the JMS 2.0 API, and update org.apache.tomee:javaee-api to 8.0 (this covers JMS 2.0)
* Remove the janino dependency (unless its needed for something that I have missed)
You could also check out this JIRA: https://issues.apache.org/jira/browse/TOMEE-2162, and this commit: https://github.com/apache/tomee/commit/d9f3ca8498e1696637eac569f0396b63030703b0 - I enabled activations to be specified on the container in the application's resources.xml:
```
<Container id="mdb-container">
activation.some.property = value
</Container>
```
that activation property will be applied to all the MDBs in that container - so quite handy if you need to specify the WMQ host, for example, on each MDB.
If memory serves me correctly, you can override these with system properties as well:
-D<mdb-container-id>.activation.<property> = value.
I'm happy to help with this, and we don't need all of these done to merge it in, but we would need the ASL header on the files first.
---