You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/06 23:24:45 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #1931:
[NETBEANS-3806] - cleanup hashcode in DBElementsCollection
BradWalker opened a new pull request #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931
I came across this issue in Netbeans with the DBElementsCollection class.
Basically the hascode is being returned as a String but the code removes checking for type by treating the hashcode as an object.
This change keeps it as a String and removes the folloiwng warning..
[repeat] /home/bwalker/src/netbeans/java/dbschema/src/org/netbeans/modules/dbschema/jdbcimpl/DBElementsCollection.java:41: warning: [rawtypes] found raw type: HashSet
[repeat] protected static transient HashSet instances = new HashSet();
[repeat] ^
[repeat] missing type arguments for generic class HashSet<E>
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class HashSet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1931: [NETBEANS-3806] -
cleanup hashcode in DBElementsCollection
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1931: [NETBEANS-3806] -
cleanup hashcode in DBElementsCollection
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931#issuecomment-591528877
You can add more commits to this Pull Request by pushing to the same branch. Alternatively, you can amend the commit and force-push to the same branch. Then the diff will update here.
(This is how these Pull Requests usually go--people request changes, the original submitter pushes additional commits or force-pushed amendments, etc., until everybody is happy. In the end, the chain of commits in the PR is usually "squashed" by GitHub into a single, clean commit that goes onto the NetBeans master branch.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1931: [NETBEANS-3806] -
cleanup hashcode in DBElementsCollection
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931#issuecomment-589878694
In this one there's a lot of formatting changes unrelated to the subject of the bug/description.
It's best to avoid making formatting changes for their own sake, except when the code is being changed in any case. Formatting make merges more difficult and clutters git history, e.g. when doing "git blame".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on issue #1931: [NETBEANS-3806] -
cleanup hashcode in DBElementsCollection
Posted by GitBox <gi...@apache.org>.
BradWalker commented on issue #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931#issuecomment-591027695
I agree with your comment about the formatting changes. But, I just couldn't read the code before my changes.
Since I do my changes in Netbeans, I just decided to reformat it so that I could simply read it..
But, I agree and in the future will keep the format changes to a very minimum..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on issue #1931:
[NETBEANS-3806] - cleanup hashcode in DBElementsCollection
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on issue #1931: [NETBEANS-3806] - cleanup hashcode in DBElementsCollection
URL: https://github.com/apache/netbeans/pull/1931#issuecomment-589878694
In this one there's a lot of formatting changes unrelated to the subject of the bug/description.
It's best to avoid making formatting changes for their own sake, except when the code is being changed in any case. Formatting changes make merges more difficult and clutters git history, e.g. when doing "git blame".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists