You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2015/07/21 14:39:22 UTC
[GitHub] incubator-brooklyn pull request: Fix httpclient version mismatch i...
GitHub user rdowner opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/759
Fix httpclient version mismatch in pom
In commit 3fb4d9a @andreaturli bumped the httpclient version in the parent pom, but he didn't update the version in `brooklyn-downstream-parent` pom. This was causing dependency convergence errors in downstream projects.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/incubator-brooklyn fix-httpclient-downstream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #759
----
commit 593d17590590c84d5def5539aed8006403607f86
Author: Richard Downer <ri...@apache.org>
Date: 2015-07-21T12:37:01Z
Fix httpclient version mismatch in pom
In commit 3fb4d9a @andreaturli bumped the httpclient version in the
parent pom, but he didn't update the version in
brooklyn-downstream-parent pom.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix httpclient version mismatch i...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/759#issuecomment-124153759
Thanks for the review everyone.
@CMoH there has been extensive discussion about the root pom, parent pom, and downstream pom on the ML in recent weeks. To answer your question in short, downstream-parent is intended for our downstream users to use in their pom. If it inherited from parent pom, they would pick up a lot of stuff that is needed for our build and irrelevant (and possibly conflicting) with our user's requirements.
The correct solution is to put this common stuff into the root pom that both parent pom and downstream pom inherit from. As @neykov says, this can be addressed in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix httpclient version mismatch i...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/759#issuecomment-124076073
Good to merge. Adding a pairing `dependencyManagement/dependency` to the `xxx.version` properties would be nice, but can be addressed in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix httpclient version mismatch i...
Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/759#issuecomment-123302006
Should be merged.
However, are there any specific reasons why brooklyn-downstream-parent was not parented with brooklyn-parent? That would eliminate such problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix httpclient version mismatch i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---