You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "jgneff (via GitHub)" <gi...@apache.org> on 2024/04/19 23:08:12 UTC
[PR] Import local schema to avoid DNS lookup in build [netbeans]
jgneff opened a new pull request, #7283:
URL: https://github.com/apache/netbeans/pull/7283
Please review this one-line change to the file `jakartaee_11.xsd`, which is a new file for NetBeans 22. This change in the Jakarta EE 11 file is the same as the previous changes for Jakarta EE 10 in 2023 and Jakarta EE 9 in 2022:
* #5372 (Jan 26, 2023)
* #4933 (Nov 6, 2022)
The original issue is:
* #4920 (Nov 4, 2022)
Without this fix, building NetBeans on Launchpad fails with the exception:
```
/build/snapcraft-strictly-netbeans-79a4131177e2fda97a9ea091531b589f/parts/...
netbeans/build/build-release-temp/enterprise/j2ee.dd/build.xml:219:
Failed to parse document at 'https://www.w3.org/2001/xml.xsd'.
java.net.UnknownHostException: www.w3.org
at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:567)
at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
at java.base/java.net.Socket.connect(Socket.java:633)
```
With this fix, there are no DNS lookups during the build, and the NetBeans build on Launchpad is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7283:
URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067534300
hi @jgneff,
> Did I do this right?
Depends what you are trying to do ;) `master` would target NB 23 right now, `delivery` is essentially bugfix/lowrisk-only and targets NB 22 which is in the release candidate phase.
Regarding changing the target branch of a PR: your branch should be a copy of the branch you are targeting. So if you target `delivery`, make sure your commit is on top of a copy of the delivery branch. Same for `master` etc.
You don't have to close the PR, you can simply force push into your branch (`-f`), github will catch up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7283:
URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067539743
sounds good. going to quickly lock and unlock this PR so that CI is picking up the labels. The file is also recent, so it makes sense that it started happening not too long ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "jgneff (via GitHub)" <gi...@apache.org>.
jgneff commented on PR #7283:
URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067382570
Did I do this right? I created my pull request branch `import-local-schema` from the `delivery` branch, but it seems I forgot to switch the target branch name on GitHub when submitting the pull request. Is there a way to simply move this over to the `delivery` branch, or do I need to close this and do it over? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "jgneff (via GitHub)" <gi...@apache.org>.
jgneff commented on PR #7283:
URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067715163
> @jgneff do you have the full stack trace when this happens? Ideally we would not need to fiddle with the schemas and just use a catalog to modify the resolving, just as the IDE normally does.
Here's the full stack trace: [strictly-netbeans_amd64.txt](https://github.com/apache/netbeans/files/15048800/strictly-netbeans_amd64.txt). This pull request simply loads the copy of the latest 2009 XML namespace schema that is already found on the local file system:
```
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/resources/jakartaee_11.xsd now refers to:
enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/resources/xml.xsd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #7283:
URL: https://github.com/apache/netbeans/pull/7283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Import local schema to avoid DNS lookup in build [netbeans]
Posted by "jgneff (via GitHub)" <gi...@apache.org>.
jgneff commented on PR #7283:
URL: https://github.com/apache/netbeans/pull/7283#issuecomment-2067537797
Thanks, Michael. I would like this to go into NetBeans 22, if at all possible, but I'm not able to add any labels. The build of NetBeans 22 fails for me without this fix (as it did for the same problem in 2022 and 2023).
> Depends what you are trying to do ;) `master` would target NB 23 right now, `delivery` is essentially bugfix/lowrisk-only and targets NB 22 which is in the release candidate phase.
I figured it out. (See **UPDATE** above.) I didn't realize you could edit the *base* branch in addition to the PR title when you click the Edit button at the top of the pull request on GitHub.
> Regarding changing the target branch of a PR: your branch should be a copy of the branch you are targeting. So if you target `delivery`, make sure your commit is on top of a copy of the delivery branch.
I did that. I just forgot to change the base branch on the GitHub pull request. GitHub sets the base branch to the *master* branch no matter what you have for the actual base of your pull request branch, it seems.
> You don't have to close the PR, you can simply force push into your branch (`-f`), github will catch up.
Didn't even have to do that. I just switched it in GitHub to match what I had actually done locally, which is to base my pull request branch on the *delivery* branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists