You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 21:38:49 UTC

[GitHub] [airflow] eladkal commented on pull request #22421: Add `JenkinsBuildSensor`

eladkal commented on pull request #22421:
URL: https://github.com/apache/airflow/pull/22421#issuecomment-1075668837


   Tests are failing:
   
   ```
   ==== Providers sqlite: 3 failures ====
   
   tests/providers/jenkins/sensors/test_jenkins.py::TestJenkinsBuildSensor::test_pole_0: TypeError: test_pole() missing 1 required positional argument: 'build_state'
   tests/providers/jenkins/sensors/test_jenkins.py::TestJenkinsBuildSensor::test_pole_1: TypeError: test_pole() missing 1 required positional argument: 'build_state'
   tests/providers/jenkins/sensors/test_jenkins.py::TestJenkinsBuildSensor::test_pole_2: TypeError: test_pole() missing 1 required positional argument: 'build_state'
   ```
   
   You also have some static checks failures. I suggest to follow https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst and use pre-commit it will help you to find the static problems before you push the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org