You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2022/04/04 12:34:59 UTC

[superset] branch lts-v1 updated: fix tests and lint

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch lts-v1
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/lts-v1 by this push:
     new 665766005a fix tests and lint
665766005a is described below

commit 665766005ab85233dd87978077d1df771c2828d2
Author: Ville Brofeldt <vi...@gmail.com>
AuthorDate: Mon Apr 4 15:34:11 2022 +0300

    fix tests and lint
---
 superset/common/query_object_factory.py      | 2 +-
 superset/sql_parse.py                        | 1 -
 tests/integration_tests/sqla_models_tests.py | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/superset/common/query_object_factory.py b/superset/common/query_object_factory.py
index 0066346d8a..d38c114e1d 100644
--- a/superset/common/query_object_factory.py
+++ b/superset/common/query_object_factory.py
@@ -79,7 +79,7 @@ class QueryObjectFactory:  # pylint: disable=too-few-public-methods
             str(datasource["type"]), int(datasource["id"]), self._session_maker()
         )
 
-    def _process_extras(  # pylint: disable=no-self-use
+    def _process_extras(
         self,
         extras: Optional[Dict[str, Any]],
     ) -> Dict[str, Any]:
diff --git a/superset/sql_parse.py b/superset/sql_parse.py
index 6bfb63c425..e3b2e7c196 100644
--- a/superset/sql_parse.py
+++ b/superset/sql_parse.py
@@ -574,7 +574,6 @@ def get_rls_for_table(
         return None
 
     template_processor = dataset.get_template_processor()
-    # pylint: disable=protected-access
     predicate = " AND ".join(
         str(filter_)
         for filter_ in dataset.get_sqla_row_level_filters(template_processor)
diff --git a/tests/integration_tests/sqla_models_tests.py b/tests/integration_tests/sqla_models_tests.py
index d8c9c070c9..bbe062e509 100644
--- a/tests/integration_tests/sqla_models_tests.py
+++ b/tests/integration_tests/sqla_models_tests.py
@@ -41,6 +41,7 @@ from superset.utils.core import (
     FilterOperator,
     GenericDataType,
     TemporalType,
+    backend,
 )
 from superset.utils.database import get_example_database
 from tests.integration_tests.fixtures.birth_names_dashboard import (