You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/09/30 07:40:49 UTC
[GitHub] [kylin] codecov-io edited a comment on issue #843: KYLIN-4169 remove useless listModels() in DataModelManager.curd.initE…
codecov-io edited a comment on issue #843: KYLIN-4169 remove useless listModels() in DataModelManager.curd.initE…
URL: https://github.com/apache/kylin/pull/843#issuecomment-532504822
# [Codecov](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=h1) Report
> Merging [#843](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/1e64c23c49043a426889274aacf26652d9d96d0a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `40%`.
[](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #843 +/- ##
============================================
- Coverage 25.46% 25.45% -0.02%
+ Complexity 6107 6104 -3
============================================
Files 1410 1410
Lines 84919 84918 -1
Branches 11897 11897
============================================
- Hits 21622 21612 -10
- Misses 61218 61227 +9
Partials 2079 2079
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/kylin/rest/service/ModelService.java](https://codecov.io/gh/apache/kylin/pull/843/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Nb2RlbFNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/843/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `25.45% <50%> (-9.1%)` | `9 <0> (-3)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/843/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.35% <50%> (ø)` | `71 <1> (ø)` | :arrow_down: |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/843/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/843/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=footer). Last update [1e64c23...3e90e6d](https://codecov.io/gh/apache/kylin/pull/843?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services