You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/26 16:00:17 UTC

[GitHub] [iotdb] choubenson opened a new pull request #4482: Add annotation to compaction

choubenson opened a new pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482


   Add some annotation to Compaction. Make it easier to read and understand code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on a change in pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#discussion_r760205177



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -32,26 +32,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Future;
-import java.util.concurrent.RejectedExecutionException;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
+import java.util.*;

Review comment:
       do not import *

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionTaskManager.java
##########
@@ -32,26 +32,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Future;
-import java.util.concurrent.RejectedExecutionException;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
+import java.util.*;
+import java.util.concurrent.*;
 import java.util.concurrent.atomic.AtomicInteger;
 
 /** CompactionMergeTaskPoolManager provides a ThreadPool tPro queue and run all compaction tasks. */
 public class CompactionTaskManager implements IService {
   private static final Logger logger = LoggerFactory.getLogger("COMPACTION");
   private static final CompactionTaskManager INSTANCE = new CompactionTaskManager();
+
+  // The thread pool that executes the compaction task. The number of threads for this pool is 10.

Review comment:
       The 【default】 number of threads for this pool is 10.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44677045/badge)](https://coveralls.io/builds/44677045)
   
   Coverage increased (+0.1%) to 67.427% when pulling **1b690f1d64af464d3dae1215a8c7c18f80946a41 on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44731082/badge)](https://coveralls.io/builds/44731082)
   
   Coverage decreased (-0.05%) to 67.27% when pulling **539b40dc49706a5ffab169e676d9a4323cdb279b on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44709387/badge)](https://coveralls.io/builds/44709387)
   
   Coverage decreased (-0.02%) to 67.299% when pulling **e09700dce7d1be53b127bb902e269beec89a93c8 on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] choubenson closed pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
choubenson closed pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44571114/badge)](https://coveralls.io/builds/44571114)
   
   Coverage increased (+0.03%) to 67.351% when pulling **003f8da69e153262ee2227f4133980d00ba80252 on choubenson:addAnnotationToCompaction** into **6487443cbb971f718f3b310c651ef754cb601ee9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44658326/badge)](https://coveralls.io/builds/44658326)
   
   Coverage increased (+0.001%) to 67.323% when pulling **1fdf5254a3339a1eb995d5872528373da4cca365 on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44570763/badge)](https://coveralls.io/builds/44570763)
   
   Coverage increased (+0.04%) to 67.358% when pulling **003f8da69e153262ee2227f4133980d00ba80252 on choubenson:addAnnotationToCompaction** into **6487443cbb971f718f3b310c651ef754cb601ee9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44710286/badge)](https://coveralls.io/builds/44710286)
   
   Coverage decreased (-0.05%) to 67.271% when pulling **e09700dce7d1be53b127bb902e269beec89a93c8 on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4482: Add annotation to compaction

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4482:
URL: https://github.com/apache/iotdb/pull/4482#issuecomment-980134964


   
   [![Coverage Status](https://coveralls.io/builds/44731175/badge)](https://coveralls.io/builds/44731175)
   
   Coverage decreased (-0.03%) to 67.29% when pulling **539b40dc49706a5ffab169e676d9a4323cdb279b on choubenson:addAnnotationToCompaction** into **cbb09d0b99fa9317de06a277c4ee393a577029e9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org