[GitHub] [flink] twalthr commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #9994: [FLINK-14322][table-api] Add watermark information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r345127910
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
 ##########
 @@ -343,13 +396,30 @@ public Builder field(String name, TypeInformation<?> typeInfo) {
 			return field(name, fromLegacyInfoToDataType(typeInfo));
 		}
 
+		/**
+		 * Specifies the previously defined field as an event-time attribute and specifies the watermark strategy.
+		 *
+		 * @param rowtimeAttribute the field name as a rowtime attribute, can be a nested field using dot separator.
+		 * @param watermarkStrategy the watermark strategy expression
+		 */
+		public Builder watermark(String rowtimeAttribute, ResolvedExpression watermarkStrategy) {
 
 Review comment:
   I think using plain strings in Java classes should be avoided in general. This is not very object oriented. I understand that constructing `ResolvedExpression` might be difficult at certain locations but we could also use just `Expression`. Actually, a SQL string is also just an unresolved expression until it has been parsed and validated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services