You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/09 20:31:30 UTC
[GitHub] nswamy commented on a change in pull request #11596: [MXNET-531]
Integration Test for Scala
nswamy commented on a change in pull request #11596: [MXNET-531] Integration Test for Scala
URL: https://github.com/apache/incubator-mxnet/pull/11596#discussion_r201137041
##########
File path: Makefile
##########
@@ -593,7 +593,13 @@ scalapkg:
-Dcurrent_libdir="$(ROOTDIR)/lib" \
-Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a")
-scalatest:
+scalaunittest:
+ (cd $(ROOTDIR)/scala-package; \
+ mvn integration-test -P$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE) -Dcxx="$(CXX)" \
+ -Dcflags="$(CFLAGS)" -Dldflags="$(LDFLAGS)" \
+ -Dlddeps="$(LIB_DEP) $(ROOTDIR)/lib/libmxnet.a" $(SCALA_TEST_ARGS))
+
+scalaintegrationtest:
Review comment:
where do you specify to run tests only under examples ? does it also run unit tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services