You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 21:33:10 UTC
[GitHub] [airflow] kaxil opened a new pull request #21915: Unpin ``pandas-gbq`` and remove unused code
kaxil opened a new pull request #21915:
URL: https://github.com/apache/airflow/pull/21915
`BigQueryPandasConnector` was previously used by `BigqueryHook.get_pandas_df`. This was fixed in https://github.com/apache/airflow/commit/ad308ea441372f2b44b4292c3779eb745f2ed48c . However we forgot to remove `BigQueryPandasConnector` which is age-old code (2016) and used private methods.
2016 code - https://github.com/apache/airflow/pull/1452/files
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21915:
URL: https://github.com/apache/airflow/pull/21915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#issuecomment-1055938872
Single SQLite failure is unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#issuecomment-1055948338
Any backcompat concerns? We can bump the major for the provider easy enough, but not as straight forward with the contrib in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#issuecomment-1056003315
> Any backcompat concerns? We can bump the major for the provider easy enough, but not as straight forward with the contrib in core.
Hardly think so, ancient code that doesn't make sense to use in isolation. `BigQueryPandasConnector` was previously used by `BigqueryHook.get_pandas_df`. This was fixed in https://github.com/apache/airflow/commit/ad308ea441372f2b44b4292c3779eb745f2ed48c (**in 2018**). However we forgot to remove `BigQueryPandasConnector` which is age-old code (2016) and used private methods.
So I don'g see any concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#issuecomment-1056326977
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#discussion_r817248655
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -24,8 +24,6 @@
BigQueryConnection,
BigQueryCursor,
BigQueryHook,
- BigQueryPandasConnector,
- GbqConnector,
Review comment:
Added in https://github.com/apache/airflow/pull/21915/commits/cdcb619c8aeabd7a04c3dd4bafccf503b4d30851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#discussion_r817214541
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -24,8 +24,6 @@
BigQueryConnection,
BigQueryCursor,
BigQueryHook,
- BigQueryPandasConnector,
- GbqConnector,
Review comment:
If we leave this, one less backcompat break?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21915: Unpin ``pandas-gbq`` and remove unused code
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21915:
URL: https://github.com/apache/airflow/pull/21915#issuecomment-1056504676
Hell yeah :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org