You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by et...@apache.org on 2008/03/12 09:25:45 UTC

svn commit: r636248 - /incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java

Author: etnu
Date: Wed Mar 12 01:25:42 2008
New Revision: 636248

URL: http://svn.apache.org/viewvc?rev=636248&view=rev
Log:
Fixes SHINDIG-110 by treating an empty rvalue for the libs parameter as "core".


Modified:
    incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java

Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java?rev=636248&r1=636247&r2=636248&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderer.java Wed Mar 12 01:25:42 2008
@@ -156,13 +156,14 @@
     StringBuilder inlineJs = new StringBuilder();
     String externFmt = "<script src=\"%s\"></script>";
     String forcedLibs = request.getParameter("libs");
-    Set<String> libs;
-    if (forcedLibs == null) {
-      libs = new HashSet<String>();
-    } else {
-      libs = new HashSet<String>();
-      for (String lib : forcedLibs.split(":")) {
-        libs.add(lib);
+    Set<String> libs = new HashSet<String>();
+    if (forcedLibs != null) {
+      if (forcedLibs.trim().length() == 0) {
+        libs.add("core");
+      } else {
+        for (String lib : forcedLibs.split(":")) {
+          libs.add(lib);
+        }
       }
     }