You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Greg Hill <gr...@rackspace.com> on 2016/03/02 20:54:26 UTC
Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-15266
https://issues.apache.org/jira/browse/AMBARI-15266
Repository: ambari
Description
-------
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Diffs
-----
ambari-agent/conf/unix/ambari-agent.ini 80afdb2
ambari-agent/conf/windows/ambari-agent.ini 1b24f25
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
Diff: https://reviews.apache.org/r/44285/diff/
Testing
-------
New unit tests cover the behavior.
Thanks,
Greg Hill
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Greg Hill <gr...@rackspace.com>.
> On March 4, 2016, 9:36 p.m., Jayush Luniya wrote:
> > ambari-agent/src/main/python/ambari_agent/FileCache.py, line 200
> > <https://reviews.apache.org/r/44285/diff/4/?file=1279848#file1279848line200>
> >
> > Hmm, I was expecting it to be an annotation @retry. See https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45
Does it matter? It accomplishes the same thing. There's literally no benefit to making another function inside of that method just to use it as a decorator.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review122152
-----------------------------------------------------------
On March 3, 2016, 7:56 p.m., Greg Hill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 7:56 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 05e898a
> ambari-agent/conf/windows/ambari-agent.ini e490f7c
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa
> ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
>
> Diff: https://reviews.apache.org/r/44285/diff/
>
>
> Testing
> -------
>
> New unit tests cover the behavior.
>
>
> Thanks,
>
> Greg Hill
>
>
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review122152
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/FileCache.py (line 200)
<https://reviews.apache.org/r/44285/#comment184049>
Hmm, I was expecting it to be an annotation @retry. See https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45
- Jayush Luniya
On March 3, 2016, 7:56 p.m., Greg Hill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 7:56 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 05e898a
> ambari-agent/conf/windows/ambari-agent.ini e490f7c
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa
> ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
>
> Diff: https://reviews.apache.org/r/44285/diff/
>
>
> Testing
> -------
>
> New unit tests cover the behavior.
>
>
> Thanks,
>
> Greg Hill
>
>
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review123455
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On March 3, 2016, 7:56 p.m., Greg Hill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 7:56 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 05e898a
> ambari-agent/conf/windows/ambari-agent.ini e490f7c
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa
> ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
>
> Diff: https://reviews.apache.org/r/44285/diff/
>
>
> Testing
> -------
>
> New unit tests cover the behavior.
>
>
> Thanks,
>
> Greg Hill
>
>
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Greg Hill <gr...@rackspace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/
-----------------------------------------------------------
(Updated March 3, 2016, 7:56 p.m.)
Review request for Ambari.
Changes
-------
Rebased
Bugs: AMBARI-15266
https://issues.apache.org/jira/browse/AMBARI-15266
Repository: ambari
Description
-------
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 05e898a
ambari-agent/conf/windows/ambari-agent.ini e490f7c
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 01e8daa
ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
Diff: https://reviews.apache.org/r/44285/diff/
Testing
-------
New unit tests cover the behavior.
Thanks,
Greg Hill
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Greg Hill <gr...@rackspace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/
-----------------------------------------------------------
(Updated March 3, 2016, 1:28 p.m.)
Review request for Ambari.
Changes
-------
Used the existing retry mechanism rather than writing my own.
Bugs: AMBARI-15266
https://issues.apache.org/jira/browse/AMBARI-15266
Repository: ambari
Description
-------
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 80afdb2
ambari-agent/conf/windows/ambari-agent.ini 1b24f25
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
Diff: https://reviews.apache.org/r/44285/diff/
Testing
-------
New unit tests cover the behavior.
Thanks,
Greg Hill
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Greg Hill <gr...@rackspace.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/
-----------------------------------------------------------
(Updated March 2, 2016, 8:27 p.m.)
Review request for Ambari.
Changes
-------
Fixed an indentation inconsistency.
Bugs: AMBARI-15266
https://issues.apache.org/jira/browse/AMBARI-15266
Repository: ambari
Description
-------
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent.ini 80afdb2
ambari-agent/conf/windows/ambari-agent.ini 1b24f25
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
Diff: https://reviews.apache.org/r/44285/diff/
Testing
-------
New unit tests cover the behavior.
Thanks,
Greg Hill
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Greg Hill <gr...@rackspace.com>.
> On March 2, 2016, 8:27 p.m., Jayush Luniya wrote:
> > ambari-agent/src/main/python/ambari_agent/FileCache.py, line 198
> > <https://reviews.apache.org/r/44285/diff/1/?file=1278063#file1278063line198>
> >
> > See if you can use the retry decorator instead.
> >
> > https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/decorator.py#L29
> >
> > Sample Usage:
> > https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45
I wasn't aware of it. I can give it a shot.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review121712
-----------------------------------------------------------
On March 2, 2016, 8:27 p.m., Greg Hill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 8:27 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 80afdb2
> ambari-agent/conf/windows/ambari-agent.ini 1b24f25
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
> ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
>
> Diff: https://reviews.apache.org/r/44285/diff/
>
>
> Testing
> -------
>
> New unit tests cover the behavior.
>
>
> Thanks,
>
> Greg Hill
>
>
Re: Review Request 44285: AMBARI-15266 - Add configurable download
retries for cache misses
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44285/#review121712
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/FileCache.py (line 198)
<https://reviews.apache.org/r/44285/#comment183494>
See if you can use the retry decorator instead.
https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/decorator.py#L29
Sample Usage:
https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py#L45
- Jayush Luniya
On March 2, 2016, 7:54 p.m., Greg Hill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44285/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 7:54 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15266
> https://issues.apache.org/jira/browse/AMBARI-15266
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent.ini 80afdb2
> ambari-agent/conf/windows/ambari-agent.ini 1b24f25
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 2c82ca5
> ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee
> ambari-agent/src/test/python/ambari_agent/TestFileCache.py 5933daa
>
> Diff: https://reviews.apache.org/r/44285/diff/
>
>
> Testing
> -------
>
> New unit tests cover the behavior.
>
>
> Thanks,
>
> Greg Hill
>
>
Re: Who reviews ambari-agent patches?
Posted by Sumit Mohanty <sm...@hortonworks.com>.
You can add DmytriL and AndrewO (in CC).
-Sumit
________________________________________
From: Greg Hill <gr...@RACKSPACE.COM>
Sent: Wednesday, March 02, 2016 11:57 AM
To: Greg Hill; Ambari
Subject: Who reviews ambari-agent patches?
This is a behavior that has broken us multiple times. Can I get some eyes on this patch?
Greg
From: Greg <gr...@rackspace.com>>
Reply-To: Greg <gr...@rackspace.com>>
Date: Wednesday, March 2, 2016 at 1:54 PM
To: Greg <gr...@rackspace.com>>, Ambari <de...@ambari.apache.org>>
Subject: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44285/
Review request for Ambari.
By Greg Hill.
Bugs: AMBARI-15266<https://issues.apache.org/jira/browse/AMBARI-15266>
Repository: ambari
Description
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Testing
New unit tests cover the behavior.
Diffs
* ambari-agent/conf/unix/ambari-agent.ini (80afdb2)
* ambari-agent/conf/windows/ambari-agent.ini (1b24f25)
* ambari-agent/src/main/python/ambari_agent/AmbariConfig.py (2c82ca5)
* ambari-agent/src/main/python/ambari_agent/FileCache.py (b7c5dee)
* ambari-agent/src/test/python/ambari_agent/TestFileCache.py (5933daa)
View Diff<https://reviews.apache.org/r/44285/diff/>
Who reviews ambari-agent patches?
Posted by Greg Hill <gr...@RACKSPACE.COM>.
This is a behavior that has broken us multiple times. Can I get some eyes on this patch?
Greg
From: Greg <gr...@rackspace.com>>
Reply-To: Greg <gr...@rackspace.com>>
Date: Wednesday, March 2, 2016 at 1:54 PM
To: Greg <gr...@rackspace.com>>, Ambari <de...@ambari.apache.org>>
Subject: Review Request 44285: AMBARI-15266 - Add configurable download retries for cache misses
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44285/
Review request for Ambari.
By Greg Hill.
Bugs: AMBARI-15266<https://issues.apache.org/jira/browse/AMBARI-15266>
Repository: ambari
Description
Adds configuration options to tell ambari-agent to retry attempts to download the custom script cache from ambari-server
Testing
New unit tests cover the behavior.
Diffs
* ambari-agent/conf/unix/ambari-agent.ini (80afdb2)
* ambari-agent/conf/windows/ambari-agent.ini (1b24f25)
* ambari-agent/src/main/python/ambari_agent/AmbariConfig.py (2c82ca5)
* ambari-agent/src/main/python/ambari_agent/FileCache.py (b7c5dee)
* ambari-agent/src/test/python/ambari_agent/TestFileCache.py (5933daa)
View Diff<https://reviews.apache.org/r/44285/diff/>