You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/14 00:09:51 UTC
[GitHub] kristw commented on issue #6386: [bugfix] prevent d3-format from
raising
kristw commented on issue #6386: [bugfix] prevent d3-format from raising
URL: https://github.com/apache/incubator-superset/pull/6386#issuecomment-438487415
Thanks for the fix. I am also addressing this in the `@superset-ui/number-format` package I am working on. This PR should help with master stability meanwhile.
BTW, if the format is invalid (e.g. `.abcx`). Should we still show the raw value
e.g. `12345 (Invalid format: .abcx)` instead of `ERROR`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org