You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:27:41 UTC
[GitHub] [trafficserver] maskit opened a new pull request #7063: Add an autest testcase for HTTP3
maskit opened a new pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063
This extends autest a little and adds a test case for active timeout on HTTP/3.
This works on my env (curl built with ngtcp2 and nghttp3) but still WIP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit edited a comment on pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit edited a comment on pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#issuecomment-666110905
Running this autest on CI box would be tricky. We'd need special curl built with a QUIC library and the QUIC version the library supports has to match with the one ATS supports. Currently, 9.0.x and master supports 27 and quic-latest supports both 27 and 29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#issuecomment-671724980
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#issuecomment-681460524
@zwoop Do you have any concern on this? Running this on CI may be tricky, but I think this addition itself should not harm anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit merged pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#discussion_r462732167
##########
File path: tests/gold_tests/autest-site/trafficserver.test.ext
##########
@@ -304,15 +304,23 @@ def MakeATSProcess(obj, name, command='traffic_server', select_ports=True,
'proxy.config.http.cache.http': 0
})
+ if enable_quic:
+ p.Disk.records_config.update({
+ 'proxy.config.udp.threads': 1,
+ })
+
# The following message was added so that tests and users can know when
# Traffic Server is ready to both receive and optimize traffic.
p.Ready = When.FileContains(p.Disk.diags_log.AbsPath, "NOTE: Traffic Server is fully initialized")
if select_ports:
# default config
- port_str = "{port} {v6_port}:ipv6 ".format(port=p.Variables.port, v6_port=p.Variables.portv6)
+ port_str = "{port} {v6_port}:ipv6".format(port=p.Variables.port, v6_port=p.Variables.portv6)
if enable_tls:
- port_str += "{ssl_port}:ssl {ssl_portv6}:ssl:ipv6".format(
+ port_str += " {ssl_port}:ssl {ssl_portv6}:ssl:ipv6".format(
+ ssl_port=p.Variables.ssl_port, ssl_portv6=p.Variables.ssl_portv6)
+ if enable_quic:
+ port_str += " {ssl_port}:quic {ssl_portv6}:quic:ipv6".format(
Review comment:
I reused ssl port *number* for QUIC. If the port number was 2000 (random number), both TCP 2000 and UDP 2000 would open.
##########
File path: tests/gold_tests/timeout/active_timeout.test.py
##########
@@ -60,3 +60,8 @@
tr3= Test.AddTestRun("tr")
tr3.Processes.Default.Command = 'curl -k -i --http2 https://127.0.0.1:{0}/file'.format(ts.Variables.ssl_port)
tr3.Processes.Default.Streams.stdout = Testers.ContainsExpression("Activity Timeout", "Request should fail with active timeout")
+
+if Condition.HasCurlFeature('http3'):
Review comment:
This also needs to check HasATSFeature('http3').
##########
File path: tests/gold_tests/autest-site/trafficserver.test.ext
##########
@@ -304,15 +304,23 @@ def MakeATSProcess(obj, name, command='traffic_server', select_ports=True,
'proxy.config.http.cache.http': 0
})
+ if enable_quic:
+ p.Disk.records_config.update({
+ 'proxy.config.udp.threads': 1,
+ })
+
# The following message was added so that tests and users can know when
# Traffic Server is ready to both receive and optimize traffic.
p.Ready = When.FileContains(p.Disk.diags_log.AbsPath, "NOTE: Traffic Server is fully initialized")
if select_ports:
# default config
- port_str = "{port} {v6_port}:ipv6 ".format(port=p.Variables.port, v6_port=p.Variables.portv6)
+ port_str = "{port} {v6_port}:ipv6".format(port=p.Variables.port, v6_port=p.Variables.portv6)
if enable_tls:
- port_str += "{ssl_port}:ssl {ssl_portv6}:ssl:ipv6".format(
+ port_str += " {ssl_port}:ssl {ssl_portv6}:ssl:ipv6".format(
+ ssl_port=p.Variables.ssl_port, ssl_portv6=p.Variables.ssl_portv6)
+ if enable_quic:
+ port_str += " {ssl_port}:quic {ssl_portv6}:quic:ipv6".format(
Review comment:
I reused ssl port *number* for QUIC. If the port number was 2000 (random number), both TCP 2000 and UDP 2000 would open (if both enable_tls and enable_quic are true).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#issuecomment-666110905
Running this autest on CI box would be tricky. We'd need special curl built with a QUIC library and the QUIC version the library supports has to match with the one ATS supports. Currently, 9.0.x and master supports 27 and quic-latest supports 29.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#issuecomment-667783083
Updated the test condition to check if ATS is built with QUIC enabled, in addition to the check for HTTP/3 support of curl. The check for QUIC depends on #7074.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on a change in pull request #7063: Add an autest testcase for HTTP3
Posted by GitBox <gi...@apache.org>.
dragon512 commented on a change in pull request #7063:
URL: https://github.com/apache/trafficserver/pull/7063#discussion_r486611867
##########
File path: tests/gold_tests/timeout/active_timeout.test.py
##########
@@ -60,3 +60,8 @@
tr3= Test.AddTestRun("tr")
tr3.Processes.Default.Command = 'curl -k -i --http2 https://127.0.0.1:{0}/file'.format(ts.Variables.ssl_port)
tr3.Processes.Default.Streams.stdout = Testers.ContainsExpression("Activity Timeout", "Request should fail with active timeout")
+
+if Condition.HasCurlFeature('http3'):
Review comment:
I am good with this.. the general question is if @zwoop is concerned with a test being skipped with no message that it was. I know he has a feature request in AuTest to have an option to force skipped test to be reported as an error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org