You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/21 21:56:58 UTC
[jira] [Commented] (BEAM-1194) DataflowRunner should test a variety
of valid tempLocation/stagingLocation/etc formats.
[ https://issues.apache.org/jira/browse/BEAM-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768285#comment-15768285 ]
ASF GitHub Bot commented on BEAM-1194:
--------------------------------------
GitHub user dhalperi reopened a pull request:
https://github.com/apache/incubator-beam/pull/1671
[BEAM-1194] Add DataflowLocationIT
Opening PR to test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/incubator-beam trailing-slash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1671
----
commit 7ad2ebd8e96a469e38c156de2d2701e500c3d955
Author: Dan Halperin <dh...@google.com>
Date: 2016-12-21T01:56:00Z
Add DataflowLocationIT
----
> DataflowRunner should test a variety of valid tempLocation/stagingLocation/etc formats.
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-1194
> URL: https://issues.apache.org/jira/browse/BEAM-1194
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Daniel Halperin
> Assignee: Daniel Halperin
> Priority: Minor
>
> Cloud Dataflow has a minor history of small bugs related to various code paths expecting there to be or not be a trailing forward-slash in these location fields. The way that Beam's integration tests are set up, we are likely to only have one of these two cases tested (there is a single set of integration test pipeline options).
> We should add a dedicated DataflowRunner integration test to handle this case.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)