You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2026/08/05 02:40:09 UTC
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24660
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
IMPALA-15240: Change the error message after RANGER-5714
This patch changes the expected error message when an unauthorized user
attempts to grant/revoke a role to/from another principal after
RANGER-5714, which changed error message returned to the client in this
scenario.
Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
---
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/24660/1
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24660 )
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 12
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Aug 2026 23:50:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24660 )
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
IMPALA-15240: Change the error message after RANGER-5714
This patch changes the expected error message when an unauthorized user
attempts to grant/revoke a role to/from another principal after
RANGER-5714, which changed error message returned to the client in this
scenario.
Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Reviewed-on: http://gerrit.cloudera.org:8080/24660
Reviewed-by: Fang-Yu Rao <fa...@cloudera.com>
Tested-by: Fang-Yu Rao <fa...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke_admin_option.test
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Fang-Yu Rao: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 13
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24660 )
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
Patch Set 12: Code-Review+2
Carry forward Michael's +2.
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 12
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Aug 2026 17:04:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24660 )
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 19:48:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15240: Change the error message after RANGER-5714
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24660 )
Change subject: IMPALA-15240: Change the error message after RANGER-5714
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23522/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ce3aec7b713ed1184993a723a25439e6660de2
Gerrit-Change-Number: 24660
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 03:01:42 +0000
Gerrit-HasComments: No