You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/22 09:55:05 UTC
[GitHub] [dubbo-go] beiwei30 opened a new pull request #955: introduce a export flag to decide if a service should be export
beiwei30 opened a new pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955
it is particularly useful with a config-post-processor
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Introduce a export flag to align with java implementation. It is particularly useful when a config post processor decides to break the exporting process.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Patrick0308 merged pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
Patrick0308 merged pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955#issuecomment-749494876
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=h1) Report
> Merging [#955](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=desc) (06a21fe) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f8c8593d99231db59817afb516918d49048e371a?el=desc) (f8c8593) will **decrease** coverage by `0.12%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #955 +/- ##
===========================================
- Coverage 60.08% 59.96% -0.13%
===========================================
Files 261 260 -1
Lines 12905 12898 -7
===========================================
- Hits 7754 7734 -20
- Misses 4183 4210 +27
+ Partials 968 954 -14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `54.79% <75.00%> (-7.71%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `40.95% <0.00%> (-12.77%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.59%)` | :arrow_down: |
| [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `89.32% <0.00%> (+0.85%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `81.63% <0.00%> (+1.43%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `81.52% <0.00%> (+4.34%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `69.60% <0.00%> (+5.28%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=footer). Last update [f8c8593...ea5e28b](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955#issuecomment-749494876
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=h1) Report
> Merging [#955](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=desc) (59d4e4e) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f8c8593d99231db59817afb516918d49048e371a?el=desc) (f8c8593) will **decrease** coverage by `0.25%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #955 +/- ##
===========================================
- Coverage 60.27% 60.02% -0.26%
===========================================
Files 261 261
Lines 12905 12910 +5
===========================================
- Hits 7779 7749 -30
- Misses 4160 4205 +45
+ Partials 966 956 -10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `55.03% <80.00%> (-7.47%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `40.95% <0.00%> (-12.77%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=footer). Last update [f8c8593...59d4e4e](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955#issuecomment-749494876
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=h1) Report
> Merging [#955](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=desc) (dc2f8e3) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f8c8593d99231db59817afb516918d49048e371a?el=desc) (f8c8593) will **decrease** coverage by `0.32%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #955 +/- ##
===========================================
- Coverage 60.27% 59.95% -0.33%
===========================================
Files 261 261
Lines 12905 12909 +4
===========================================
- Hits 7779 7739 -40
- Misses 4160 4210 +50
+ Partials 966 960 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `54.72% <75.00%> (-7.78%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `40.95% <0.00%> (-12.77%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=footer). Last update [f8c8593...59d4e4e](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] beiwei30 commented on pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
beiwei30 commented on pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955#issuecomment-749495012
merge the develop to solve the conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #955: introduce a export flag to decide if a service should be export
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #955:
URL: https://github.com/apache/dubbo-go/pull/955#issuecomment-749494876
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=h1) Report
> Merging [#955](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=desc) (59d4e4e) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/f8c8593d99231db59817afb516918d49048e371a?el=desc) (f8c8593) will **decrease** coverage by `0.20%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #955 +/- ##
===========================================
- Coverage 60.27% 60.07% -0.21%
===========================================
Files 261 261
Lines 12905 12910 +5
===========================================
- Hits 7779 7756 -23
- Misses 4160 4199 +39
+ Partials 966 955 -11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `55.03% <80.00%> (-7.47%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `40.95% <0.00%> (-12.77%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.62% <0.00%> (+0.54%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/955/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `71.36% <0.00%> (+2.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=footer). Last update [f8c8593...59d4e4e](https://codecov.io/gh/apache/dubbo-go/pull/955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org