You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2012/11/11 11:45:28 UTC

Review Request: ant checkstyle results in errors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8010/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

cosmetic patch to solve ant checkstyle errors


This addresses bug SQOOP-657.
    https://issues.apache.org/jira/browse/SQOOP-657


Diffs
-----

  src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 7ac1a79 

Diff: https://reviews.apache.org/r/8010/diff/


Testing
-------

ant checkstyle reports no errors, ant test was done


Thanks,

Alexander Alten-Lorenz

Re: Review Request: ant checkstyle results in errors

Posted by Jarek Cecho <ja...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8010/#review13344
-----------------------------------------------------------

Ship it!


That patch looks good to me, I'll commit it shortly!

Jarcec

- Jarek Cecho


On Nov. 11, 2012, 10:45 a.m., Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8010/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2012, 10:45 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> cosmetic patch to solve ant checkstyle errors
> 
> 
> This addresses bug SQOOP-657.
>     https://issues.apache.org/jira/browse/SQOOP-657
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java 7ac1a79 
> 
> Diff: https://reviews.apache.org/r/8010/diff/
> 
> 
> Testing
> -------
> 
> ant checkstyle reports no errors, ant test was done
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>