You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/08 05:48:32 UTC

[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #1563: discuss: the "Host" in the active health check should be optional

Firstsawyou opened a new issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563


   # Feature request
   
   ## Please describe your feature
   
   In the active health check, Host is the host name of the HTTP request used to discover the health of the upstream node. It is required only when the upstream node has restrictions on Host, otherwise it is optional. In the current active check configuration, `Host` is a required option. I think it would be better if Host should be an optional option.
   
   ## Describe the solution you'd like
   
   It would be better if the `Host` configuration is an option in the active check configuration.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792761708


   @guoqqqi I remember there was a similar issue, right


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793654742


   agree +1
   
   "host" should be optional
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793193091


   IMO, "host" should be optional.
   @nic-chen @membphis please check the lua-resty-healthcheck.
   @Firstsawyou this issue should @ to apisix too. It is not just a FE issue 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793359859


   > IMO, "host" should be optional.
   > @nic-chen @membphis please check the lua-resty-healthcheck.
   > @Firstsawyou this issue should @ to apisix too. It is not just a FE issue
   
   OK, I will check the lib ` lua-resty-healthcheck` to confirm it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-822318456


   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792761708


   @guoqqqi I remember there was a similar issue, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792765589


   Yes, please refer to #1551.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793473185


   > IMO, "host" should be optional.
   
   agree this +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on issue #1563: discuss: the "Host" in the active health check should be optional

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1563:
URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793193822


   What does the text hint in the input box mean?
   “active host” is confusing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org