[GitHub] [helix] rabashizade commented on pull request #2120: Fix failing ZkClient TTL test

[GitBox <gi...@apache.org>]

rabashizade commented on PR #2120:
URL: https://github.com/apache/helix/pull/2120#issuecomment-1144040915

   > A general question: can we just make the tests sequential? IMO has different system properties are necessary for a better test coverage.
   
   This is a good point. I realized the tests are indeed being executed sequentially. However, different methods from different classes can be interleaved, e.g., not all tests from the class A finish before tests from class B start. It could be that some tests from class A run, then some from class B, and so on. This caused the test failure, and so I updated the property and the beginning and end of every method that needs it. Now the tests succeed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org