[GitHub] [bahir-flink] eskabetxe commented on a diff in pull request #161: [BAHIR-321] Make KuduFilterInfo handle String literals

[GitBox <gi...@apache.org>]

eskabetxe commented on code in PR #161:
URL: https://github.com/apache/bahir-flink/pull/161#discussion_r1062260924


##########
flink-connector-kudu/src/main/java/org/apache/flink/connectors/kudu/connector/KuduFilterInfo.java:
##########
@@ -65,7 +65,7 @@ private KuduPredicate predicateComparator(ColumnSchema column) {
 
         switch (column.getType()) {
             case STRING:
-                predicate = KuduPredicate.newComparisonPredicate(column, comparison, (String) this.value);
+                predicate = KuduPredicate.newComparisonPredicate(column, comparison, String.valueOf(this.value));

Review Comment:
   this is changing the behaviour a lot no? 
   for example a number that previous will fail now will be correct..
   
   Shouldn't we just check if it is a BinaryStringData (or StringData) and if so, transforme it to string, otherwise leave the previous code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org