[GitHub] [iceberg] rdblue commented on a diff in pull request #5949: Python: Visitor to convert Iceberg to PyArrow schema

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5949:
URL: https://github.com/apache/iceberg/pull/5949#discussion_r996208857


##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -23,10 +23,16 @@
 """
 
 import os
-from functools import lru_cache
-from typing import Callable, Tuple, Union
+from functools import lru_cache, singledispatch
+from typing import (
+    Callable,
+    List,
+    Tuple,
+    Union,
+)
 from urllib.parse import urlparse
 
+import pyarrow as pa

Review Comment:
   Is this file the right location for `pyarrow` conversions? This is an implementation of `FileIO` so I don't know that it fits to put schema conversion here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org