You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/08 09:05:09 UTC
[GitHub] [iotdb] jun0315 opened a new pull request #4091: [IOTDB-1798]Compatibility of Apache IoTDB with InfluxDB - More function support
jun0315 opened a new pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091
complete close, ping and version func
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 commented on pull request #4091: [IOTDB-1798] Compatibility of Apache IoTDB with InfluxDB - `flush` / `ping` / `version`
Posted by GitBox <gi...@apache.org>.
jun0315 commented on pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091#issuecomment-939219822
Thanks for your review. I have fix it. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 edited a comment on pull request #4091: [IOTDB-1798] Compatibility of Apache IoTDB with InfluxDB - `flush` / `ping` / `version`
Posted by GitBox <gi...@apache.org>.
jun0315 edited a comment on pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091#issuecomment-939219822
@SteveYurongSu Thanks for your review. I have fixed it. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4091: [IOTDB-1798] Compatibility of Apache IoTDB with InfluxDB - `flush` / `ping` / `version`
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 edited a comment on pull request #4091: [IOTDB-1798] Compatibility of Apache IoTDB with InfluxDB - `flush` / `ping` / `version`
Posted by GitBox <gi...@apache.org>.
jun0315 edited a comment on pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091#issuecomment-939219822
@SteveYurongSu Thanks for your review. I have fix it. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4091: [IOTDB-1798]Compatibility of Apache IoTDB with InfluxDB - More function support
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091#discussion_r725424079
##########
File path: influxdb-protocol/src/test/java/org/apache/iotdb/influxdb/integration/IoTDBInfluxDBIT.java
##########
@@ -99,4 +109,15 @@ public void testConnectRefusedFailed() {
public void testConnectAuthFailed() {
InfluxDB influxDB = IoTDBInfluxDBFactory.connect(host, port, "1", "1");
}
+
+ @Test
+ public void testVersion() {
+ // TODO docker image version is latest, may not 0.12.2 in the feature
+ assertEquals("0.12.2", influxDB.version());
Review comment:
```suggestion
String version = influxDB.version();
assertNotNull(version);
assertTrue(version.length() != 0);
```
##########
File path: influxdb-protocol/src/test/java/org/apache/iotdb/influxdb/integration/IoTDBInfluxDBIT.java
##########
@@ -99,4 +109,15 @@ public void testConnectRefusedFailed() {
public void testConnectAuthFailed() {
InfluxDB influxDB = IoTDBInfluxDBFactory.connect(host, port, "1", "1");
}
+
+ @Test
+ public void testVersion() {
+ // TODO docker image version is latest, may not 0.12.2 in the feature
+ assertEquals("0.12.2", influxDB.version());
+ }
+
+ @Test
+ public void testPing() {
+ assertEquals("0.12.2", influxDB.ping().getVersion());
Review comment:
```suggestion
assertTrue(influxDB.ping().getResponseTime() > 0);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org