You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/06 22:30:04 UTC

[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes

adamfeuer commented on a change in pull request #464: restore lines from bad nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/464#discussion_r389175201
 
 

 ##########
 File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h
 ##########
 @@ -103,6 +103,8 @@
 #  define SAM_ISI_OFFSET         0x00034000 /* 0x00034000-0x00037fff: ISI */
 #  define SAM_SFR_OFFSET         0x00038000 /* 0x00038000-0x0003bfff: SFR */
                                             /* 0x0003c000-0x07ffffff: Reserved */
+
 
 Review comment:
   @patacongo Will fix.
   
   Re: nxstyle bug, I'm confused about what nxstyle errors to fix or not fix. It seems like if we are going to use a tool, it should report correctly. Is there someone in the nuttx community who knows the best way to fix this bug?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services