You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/26 10:09:48 UTC
[GitHub] [arrow] milesgranger opened a new pull request, #14517: MINOR: [Parquet][Docs] Remove note on parquet RLE support
milesgranger opened a new pull request, #14517:
URL: https://github.com/apache/arrow/pull/14517
Supported now, ref [ARROW-17450](https://issues.apache.org/jira/browse/ARROW-17450) and [ARROW-18031](https://issues.apache.org/jira/browse/ARROW-18031)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on a diff in pull request #14517: MINOR: [Parquet][Docs] Update note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
milesgranger commented on code in PR #14517:
URL: https://github.com/apache/arrow/pull/14517#discussion_r1006678730
##########
docs/source/cpp/parquet.rst:
##########
@@ -102,7 +102,8 @@ Encodings
| DELTA_LENGTH_BYTE_ARRAY | ✓ | | |
+--------------------------+----------+----------+---------+
-* \(1) Only supported for encoding definition and repetition levels, not values.
+* \(1) Only supported for encoding definition, repetition levels,
Review Comment:
ah, okay. I went back and forth on that one, if those belonged together. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #14517: MINOR: [Parquet][Docs] Update note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche merged PR #14517:
URL: https://github.com/apache/arrow/pull/14517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #14517: MINOR: [Parquet][Docs] Update note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on code in PR #14517:
URL: https://github.com/apache/arrow/pull/14517#discussion_r1006641045
##########
docs/source/cpp/parquet.rst:
##########
@@ -102,7 +102,8 @@ Encodings
| DELTA_LENGTH_BYTE_ARRAY | ✓ | | |
+--------------------------+----------+----------+---------+
-* \(1) Only supported for encoding definition and repetition levels, not values.
+* \(1) Only supported for encoding definition, repetition levels,
Review Comment:
```suggestion
* \(1) Only supported for encoding definition and repetition levels,
```
(it's also "definition level", so I think it requires an "and" here to read correctly?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14517: MINOR: [Parquet][Docs] Update note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14517:
URL: https://github.com/apache/arrow/pull/14517#issuecomment-1295889889
Benchmark runs are scheduled for baseline = 5d61c62008f2f6e02951670f8d0996d90638114c and contender = 7ebd2f7113f854bd6f1b4986b52655ecd506358b. 7ebd2f7113f854bd6f1b4986b52655ecd506358b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/42f70cb10dd540c994d2ef4d8ac06d0b...69595eccbda64733bc9d8296c44d2781/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2660fcf3e0a941e7bfe2f23153b301ee...b83017ce68f4468399bc26be28bfe3af/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2a3dac41cec940fa8136e6971db2e876...86b47768360c44ce9cd51cb6806a9014/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/767e22c1d2f34fc28e6a0446a6144431...0808f3ec161e440388c5154c7e65c49a/)
Buildkite builds:
[Finished] [`7ebd2f71` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1778)
[Failed] [`7ebd2f71` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1799)
[Finished] [`7ebd2f71` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1765)
[Finished] [`7ebd2f71` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1791)
[Finished] [`5d61c620` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1777)
[Failed] [`5d61c620` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1798)
[Finished] [`5d61c620` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1764)
[Finished] [`5d61c620` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1790)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #14517: MINOR: [Parquet][Docs] Remove note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #14517:
URL: https://github.com/apache/arrow/pull/14517#issuecomment-1291841698
I would maybe keep a note, but update it to mention that it is supported _only_ for boolean type in case of values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on pull request #14517: MINOR: [Parquet][Docs] Remove note on parquet RLE support
Posted by GitBox <gi...@apache.org>.
milesgranger commented on PR #14517:
URL: https://github.com/apache/arrow/pull/14517#issuecomment-1291834540
@jorisvandenbossche
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org