You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/02 09:18:58 UTC
[jira] [Commented] (LIBCLOUD-873) Updated ProfitBricks Compute
Driver (REST api v3)
[ https://issues.apache.org/jira/browse/LIBCLOUD-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628315#comment-15628315 ]
ASF GitHub Bot commented on LIBCLOUD-873:
-----------------------------------------
GitHub user matfin opened a pull request:
https://github.com/apache/libcloud/pull/938
[LIBCLOUD-873] Updated ProfitBricks Compute Driver (REST api v3)
## Updating the ProfitBricks compute driver to work with the REST api (v3)
### Description
This PR includes changes to the ProfitBricks compute driver to drop support for the old SOAP api (now end of life) and provide support for v3 of the REST api.
All public operations provided by the new REST api are supported in this driver.
New test fixtures have been added and all tests have been amended.
A change has been added to the libcloud/common/base.py file to ensure that a request that returns with a HTTP status of 202 is not flagged as a failed request. Before this, only 200 and 201 were flagged as successful requests.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- Code linting for the compute driver implementation and the accompanying test file has been completed using the ```flake8``` tool.
- Documentation has been updated consisting of examples of using all core and extended functionality specific to ProfitBricks. A demo file with instructions on creating two servers has been put together and these will be published on the ProfitBricks community website.
- All test fixtures for api calls have been added in JSON format, replacing the older XML fixtures. All tests are passing.
### Summary of changes
Refactoring the compute driver to remove support for the EOL SOAP api and modifying api calls to use the REST api (v3).
Removing XML test fixtures and replacing them with JSON fixtures.
Providing wrappers for all new functionality provided in v3 of the Cloud API.
Addressing an issue in libcloud/common/base.py where a http status code of 202 would not be flagged as a successful request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StackPointCloud/libcloud feature/pb_api_v3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/938.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #938
----
commit bc9b0c839c1ecb2d13d0e8eafa7f17d3b5c1e6f2
Author: Matt Finucane <ma...@gmail.com>
Date: 2016-10-10T11:17:10Z
[LIBCLOUD-873] Updated ProfitBricks Compute Driver (REST api v3)
Refactoring the compute driver to remove support for the EOL SOAP api and modifying api calls to use the REST api (v3).
Removing XML test fixtures and replacing them with JSON fixtures.
Providing wrappers for all new functionality provided in v3 of the Cloud API.
Addressing an issue in libcloud/common/base.py where a http status code of 202 would not be flagged as a successful request.
----
> Updated ProfitBricks Compute Driver (REST api v3)
> -------------------------------------------------
>
> Key: LIBCLOUD-873
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-873
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Affects Versions: 0.13.3
> Environment: Linux, Windows
> Reporter: Matt Finucane
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Updated the compute driver for the ProfitBricks platform.
> This update removes the SOAP api calls and replaces them with REST calls.
> All functions documented in v3 of the ProfitBricks Cloud API are included with this driver.
> This is also related to the issue https://issues.apache.org/jira/browse/LIBCLOUD-866?filter=-2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)