[GitHub] [lucene] gf2121 commented on a diff in pull request #12324: Speed up IndexedDISI Sparse #AdvanceExactWithinBlock for tiny step advance

["gf2121 (via GitHub)" <gi...@apache.org>]

gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212892895


##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -550,32 +552,41 @@ boolean advanceWithinBlock(IndexedDISI disi, int target) throws IOException {
           if (doc >= targetInBlock) {
             disi.doc = disi.block | doc;
             disi.exists = true;
+            disi.nextExistDocInBlock = doc;
             return true;
           }
         }
+        disi.nextExistDocInBlock = Integer.MAX_VALUE;

Review Comment:
   Oh yes! `disi.index` should be enough :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org