[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8550: JsonParserIterator.init future timeout

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #8550: JsonParserIterator.init future timeout
URL: https://github.com/apache/incubator-druid/pull/8550#discussion_r325358408
 
 

 ##########
 File path: server/src/test/java/org/apache/druid/client/DirectDruidClientTest.java
 ##########
 @@ -349,4 +349,77 @@ public void testQueryInterruptionExceptionLogMessage()
     Assert.assertEquals(hostName, actualException.getHost());
     EasyMock.verify(httpClient);
   }
+
+  @Test
+  public void testQueryTimeoutFromFuture()
 
 Review comment:
   The only thing that can use the functionality introduced in this PR is `DirectDruidClient` so it doesn't seem unreasonable to me to be here. 
   
   From my perspective this was significantly _simpler for me_, since I just had to copy-pasta another test and adjust behavior to hit what I want. There isn't a  `JsonParserIteratorTest` so creating that from scratch setting up everything there to make sure it does all of its things seemed like a lot more work to the me of last night.
   
   From a completeness perspective it is probably _better_, but I am also lazy and have a bunch of other stuff I would rather be doing, so would prefer to leave this as is for now instead of write tests for _all_ of `JsonParserIterator` unless pushed hard on this.
   
   This file used to be in `DirectDruidClient` before it was moved out to its own file so it could be used by `SystemSchema` and `MetadataSegmentView`, which is probably why it doesn't have a test of its own currently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org