[GitHub] [hbase] infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #820: HBASE-23286 Improve MTTR: Split WAL to HFile
URL: https://github.com/apache/hbase/pull/820#discussion_r362731808
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitUtil.java
 ##########
 @@ -563,4 +564,58 @@ public int hashCode() {
 
     return mutations;
   }
+
+  /**
+   * Path to a file under recovered.hfiles directory of the region's column family: e.g.
+   * /hbase/some_table/2323432434/cf/recovered.hfiles/2332-wal. This method also ensures existence
 
 Review comment:
   Same with the recovered edits. Let me copy the comment here.
   // Append fileBeingSplit to prevent name conflict since we may have duplicate wal entries now.
   // Append file name ends with RECOVERED_LOG_TMPFILE_SUFFIX to ensure
   // region's replayRecoveredEdits will not delete it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services