You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Julien Vermillard <jv...@gmail.com> on 2013/04/18 10:19:58 UTC
[MINA3] M1?
Hi,
Since udp support landed in mina 3, what would be be the missing bits
before starting a M1 vote ?
Julien
Re: [MINA3] M1?
Posted by Alex Karasulu <ak...@apache.org>.
On Thu, Apr 18, 2013 at 2:00 PM, Emmanuel Lécharny <el...@gmail.com>wrote:
> Le 4/18/13 11:54 AM, Alex Karasulu a écrit :
> > On Thu, Apr 18, 2013 at 11:36 AM, Emmanuel Lécharny <elecharny@gmail.com
> >wrote:
> >
> >> Le 4/18/13 10:19 AM, Julien Vermillard a écrit :
> >>> Hi,
> >>>
> >>> Since udp support landed in mina 3, what would be be the missing bits
> >>> before starting a M1 vote ?
> >> We need to implement the UDP client. This is probably the missing bit.
> >
> > Just curious did we also gain multicast capabilities in MINA 3?
> Yes, if we expect users to depends on Java 7. This is a decision we have
> to make.
>
> IMO, as Java 6 is already EOL, we could perfectly decide to enforce such
> a constraint.
>
>
That would be most excellent since it would open the door to finally
completing so many protocols that have been waiting on this feature: i.e.
DHCP server over at Apache Directory.
--
Best Regards,
-- Alex
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/18/13 11:54 AM, Alex Karasulu a écrit :
> On Thu, Apr 18, 2013 at 11:36 AM, Emmanuel Lécharny <el...@gmail.com>wrote:
>
>> Le 4/18/13 10:19 AM, Julien Vermillard a écrit :
>>> Hi,
>>>
>>> Since udp support landed in mina 3, what would be be the missing bits
>>> before starting a M1 vote ?
>> We need to implement the UDP client. This is probably the missing bit.
>
> Just curious did we also gain multicast capabilities in MINA 3?
Yes, if we expect users to depends on Java 7. This is a decision we have
to make.
IMO, as Java 6 is already EOL, we could perfectly decide to enforce such
a constraint.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Alex Karasulu <ak...@apache.org>.
On Thu, Apr 18, 2013 at 11:36 AM, Emmanuel Lécharny <el...@gmail.com>wrote:
> Le 4/18/13 10:19 AM, Julien Vermillard a écrit :
> > Hi,
> >
> > Since udp support landed in mina 3, what would be be the missing bits
> > before starting a M1 vote ?
> We need to implement the UDP client. This is probably the missing bit.
Just curious did we also gain multicast capabilities in MINA 3?
--
Best Regards,
-- Alex
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/18/13 10:19 AM, Julien Vermillard a écrit :
> Hi,
>
> Since udp support landed in mina 3, what would be be the missing bits
> before starting a M1 vote ?
We need to implement the UDP client. This is probably the missing bit.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/19/13 6:48 PM, Julien Vermillard a écrit :
> I mean the Mina UDP test which use Netty as client and replace it by the
> Mina client.
We need both anyway...
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
I mean the Mina UDP test which use Netty as client and replace it by the
Mina client.
Le 19 mai 2013 18:21, "Emmanuel Lécharny" <el...@gmail.com> a écrit :
> Le 5/19/13 5:36 PM, Julien Vermillard a écrit :
> > I just commited the NIO UDP client.
> > I'll focus on UDP tests (both client and server).
> >
> > Would be nice if someone update the benchmarks for replacing the Netty
> > client by the new one.
>
> You mean Netty 4 ?
>
> I con do that.
> >
> > And then I think we can fire a vote for a first milestone.
>
> DO we consider SSL handling ok ? Jeff ?
>
> >
> > I think I'll try to produce a old blocking IO based UDP server For see
> how
> > it performs and if the inner code of MINA can easily accept blocking
> > transports.
>
> We have to deliver a BioUdpServer and a BioTcpServer anyway. (and the
> client too).
>
> That would be a great addition to a first milestone, but if it's not
> ready, we can add it for M2.
>
> Thanks Julien !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/19/13 6:48 PM, Emmanuel Lécharny a écrit :
> Le 5/19/13 6:27 PM, Norman Maurer a écrit :
>> If you explain me how to do I can even take care ;)
> This is pretty simple :)
>
> The code is in http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/
>
> we have benchmarks for Netty3 and MINA3, the idea is to add a
> combinaison for Netty4.
>
> The type of clients and servers are defined in the BenchmarkFactory
> class. You have to add a Netty4_udp and Netty4_tcp. Then the
> BenchmarkClientFactory and BenchmarkServerFactory class have to be
> augmented to handle the Netty4 clients and server for TCP and UDP. Those
> are pretty straghtforward modifications.
>
> Then you have to write the real flesh : in the nio/tcp and nio/udp
> packages, you have to add the classes to create the Netty4 client and
> server for UDP and TCP. This is where the initialization is done.
>
> Last, not least, the tests themselves are in some new classes names
> [Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest.
> Those new classes just have to reference the correct type defined in the
> BenchmarkFactory.
>
> Thanks a lot of the help !
>
Nad BTW, feel free to update the Netty3 code if you think we have made
some mistakes or if you can improve something !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
Yes, they changed the name ;)
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Mon, Jul 8, 2013 at 4:44 PM, Ashish <pa...@gmail.com> wrote:
> It worked. I was using mvn rat:check :(
>
>
> On Mon, Jul 8, 2013 at 8:12 PM, Julien Vermillard <jv...@gmail.com>wrote:
>
>> On Mon, Jul 8, 2013 at 11:39 AM, Ashish <pa...@gmail.com> wrote:
>> > I ran the build, it works fine and all tests passed.
>> >
>> > Would be good to add note that Java 7 is needed for the build, probably
>> ina
>> > README file or someplace.
>> >
>> > Rat check never runs on machine, always complain about .gitignore :( Any
>> > other checks you want me to run.
>>
>> You run :
>> mvn apache-rat:check
>> ?
>>
>> >
>> >
>> > On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jvermillard@gmail.com
>> >wrote:
>> >
>> >> Generated (non signed) tarballs and zip as a preview :
>> >>
>> >> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
>> >>
>> >> Can you check it before I generate the real 3.0.0-M1 release and start
>> >> the vote ?
>> >> thanks,
>> >>
>> >> --
>> >> Julien Vermillard :::: http://people.apache.org/~jvermillard/
>> >>
>> >>
>> >> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
>> >> <jv...@gmail.com> wrote:
>> >> > ok I will try to find a slice of time for generating the tarballs and
>> >> > start the vote.
>> >>
>> >
>> >
>> >
>> > --
>> > thanks
>> > ashish
>> >
>> > Blog: http://www.ashishpaliwal.com/blog
>> > My Photo Galleries: http://www.pbase.com/ashishpaliwal
>>
>
>
>
> --
> thanks
> ashish
>
> Blog: http://www.ashishpaliwal.com/blog
> My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Ashish <pa...@gmail.com>.
It worked. I was using mvn rat:check :(
On Mon, Jul 8, 2013 at 8:12 PM, Julien Vermillard <jv...@gmail.com>wrote:
> On Mon, Jul 8, 2013 at 11:39 AM, Ashish <pa...@gmail.com> wrote:
> > I ran the build, it works fine and all tests passed.
> >
> > Would be good to add note that Java 7 is needed for the build, probably
> ina
> > README file or someplace.
> >
> > Rat check never runs on machine, always complain about .gitignore :( Any
> > other checks you want me to run.
>
> You run :
> mvn apache-rat:check
> ?
>
> >
> >
> > On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jvermillard@gmail.com
> >wrote:
> >
> >> Generated (non signed) tarballs and zip as a preview :
> >>
> >> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
> >>
> >> Can you check it before I generate the real 3.0.0-M1 release and start
> >> the vote ?
> >> thanks,
> >>
> >> --
> >> Julien Vermillard :::: http://people.apache.org/~jvermillard/
> >>
> >>
> >> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
> >> <jv...@gmail.com> wrote:
> >> > ok I will try to find a slice of time for generating the tarballs and
> >> > start the vote.
> >>
> >
> >
> >
> > --
> > thanks
> > ashish
> >
> > Blog: http://www.ashishpaliwal.com/blog
> > My Photo Galleries: http://www.pbase.com/ashishpaliwal
>
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
On Mon, Jul 8, 2013 at 11:39 AM, Ashish <pa...@gmail.com> wrote:
> I ran the build, it works fine and all tests passed.
>
> Would be good to add note that Java 7 is needed for the build, probably ina
> README file or someplace.
>
> Rat check never runs on machine, always complain about .gitignore :( Any
> other checks you want me to run.
You run :
mvn apache-rat:check
?
>
>
> On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jv...@gmail.com>wrote:
>
>> Generated (non signed) tarballs and zip as a preview :
>>
>> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
>>
>> Can you check it before I generate the real 3.0.0-M1 release and start
>> the vote ?
>> thanks,
>>
>> --
>> Julien Vermillard :::: http://people.apache.org/~jvermillard/
>>
>>
>> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
>> <jv...@gmail.com> wrote:
>> > ok I will try to find a slice of time for generating the tarballs and
>> > start the vote.
>>
>
>
>
> --
> thanks
> ashish
>
> Blog: http://www.ashishpaliwal.com/blog
> My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Ashish <pa...@gmail.com>.
On Mon, Jul 8, 2013 at 6:47 PM, Emmanuel Lécharny <el...@gmail.com>wrote:
> Le 7/8/13 2:43 PM, Ashish a écrit :
> > We need to have licence for all the jars/libs we use rt?
> Yes, if they are different from AL 2.
> >
> > We need to add Licence for Netty, Thrift and log4j.
> True.
> >
> > Do we need to mention about recursive deps as well?
> No, I don't think so. We should expect that the libs we are using
> already do the job.
>
Got it. Thanks !
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 7/8/13 2:43 PM, Ashish a écrit :
> We need to have licence for all the jars/libs we use rt?
Yes, if they are different from AL 2.
>
> We need to add Licence for Netty, Thrift and log4j.
True.
>
> Do we need to mention about recursive deps as well?
No, I don't think so. We should expect that the libs we are using
already do the job.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Ashish <pa...@gmail.com>.
We need to have licence for all the jars/libs we use rt?
We need to add Licence for Netty, Thrift and log4j.
Do we need to mention about recursive deps as well?
On Mon, Jul 8, 2013 at 3:18 PM, Julien Vermillard <jv...@gmail.com>wrote:
> thanks ashish !
> could you checks the license, notice.txt and yes a readme would help :)
> --
> Julien Vermillard :::: http://people.apache.org/~jvermillard/
>
>
> On Mon, Jul 8, 2013 at 11:39 AM, Ashish <pa...@gmail.com> wrote:
> > I ran the build, it works fine and all tests passed.
> >
> > Would be good to add note that Java 7 is needed for the build, probably
> ina
> > README file or someplace.
> >
> > Rat check never runs on machine, always complain about .gitignore :( Any
> > other checks you want me to run.
> >
> >
> > On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jvermillard@gmail.com
> >wrote:
> >
> >> Generated (non signed) tarballs and zip as a preview :
> >>
> >> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
> >>
> >> Can you check it before I generate the real 3.0.0-M1 release and start
> >> the vote ?
> >> thanks,
> >>
> >> --
> >> Julien Vermillard :::: http://people.apache.org/~jvermillard/
> >>
> >>
> >> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
> >> <jv...@gmail.com> wrote:
> >> > ok I will try to find a slice of time for generating the tarballs and
> >> > start the vote.
> >>
> >
> >
> >
> > --
> > thanks
> > ashish
> >
> > Blog: http://www.ashishpaliwal.com/blog
> > My Photo Galleries: http://www.pbase.com/ashishpaliwal
>
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
thanks ashish !
could you checks the license, notice.txt and yes a readme would help :)
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Mon, Jul 8, 2013 at 11:39 AM, Ashish <pa...@gmail.com> wrote:
> I ran the build, it works fine and all tests passed.
>
> Would be good to add note that Java 7 is needed for the build, probably ina
> README file or someplace.
>
> Rat check never runs on machine, always complain about .gitignore :( Any
> other checks you want me to run.
>
>
> On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jv...@gmail.com>wrote:
>
>> Generated (non signed) tarballs and zip as a preview :
>>
>> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
>>
>> Can you check it before I generate the real 3.0.0-M1 release and start
>> the vote ?
>> thanks,
>>
>> --
>> Julien Vermillard :::: http://people.apache.org/~jvermillard/
>>
>>
>> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
>> <jv...@gmail.com> wrote:
>> > ok I will try to find a slice of time for generating the tarballs and
>> > start the vote.
>>
>
>
>
> --
> thanks
> ashish
>
> Blog: http://www.ashishpaliwal.com/blog
> My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Ashish <pa...@gmail.com>.
I ran the build, it works fine and all tests passed.
Would be good to add note that Java 7 is needed for the build, probably ina
README file or someplace.
Rat check never runs on machine, always complain about .gitignore :( Any
other checks you want me to run.
On Mon, Jul 8, 2013 at 1:15 PM, Julien Vermillard <jv...@gmail.com>wrote:
> Generated (non signed) tarballs and zip as a preview :
>
> http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
>
> Can you check it before I generate the real 3.0.0-M1 release and start
> the vote ?
> thanks,
>
> --
> Julien Vermillard :::: http://people.apache.org/~jvermillard/
>
>
> On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
> <jv...@gmail.com> wrote:
> > ok I will try to find a slice of time for generating the tarballs and
> > start the vote.
>
--
thanks
ashish
Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
Generated (non signed) tarballs and zip as a preview :
http://people.apache.org/~jvermillard/mina-3.0.0-M1-preview/
Can you check it before I generate the real 3.0.0-M1 release and start
the vote ?
thanks,
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Fri, Jun 21, 2013 at 7:45 AM, Julien Vermillard
<jv...@gmail.com> wrote:
> ok I will try to find a slice of time for generating the tarballs and
> start the vote.
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
ok I will try to find a slice of time for generating the tarballs and
start the vote.
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 6/20/13 10:25 PM, Julien Vermillard a écrit :
> I commited the distribution module, bsicly it's hte one from MINA2.
>
> I think we are good ?
I hope so ...
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
I commited the distribution module, bsicly it's hte one from MINA2.
I think we are good ?
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Sun, Jun 9, 2013 at 7:18 PM, Emmanuel Lécharny <el...@gmail.com> wrote:
> Le 6/9/13 6:50 PM, Jeff MAURY a écrit :
>> Yes,
>>
>>
>> New ssl handshake code has been merged
>
> Sure, we can.
>
> We will have to prepare the module that generates the package though.
> Let me give it a try tonite.
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 6/9/13 6:50 PM, Jeff MAURY a écrit :
> Yes,
>
>
> New ssl handshake code has been merged
Sure, we can.
We will have to prepare the module that generates the package though.
Let me give it a try tonite.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Jeff MAURY <je...@gmail.com>.
Yes,
New ssl handshake code has been merged
Jeff
—
Sent from Mailbox for iPhone
On Sun, Jun 9, 2013 at 5:15 PM, Julien Vermillard <jv...@gmail.com>
wrote:
> We so we are good no ?
> I'll do a code/javadoc review and I think we can trigger the vote.
> Julien
> --
> Julien Vermillard :::: http://people.apache.org/~jvermillard/
> On Fri, May 31, 2013 at 2:01 PM, Jeff MAURY <je...@jeffmaury.com> wrote:
>> +1 for integrating SSL into M1.
>> As i'm busy working for Eclipsecon, I'm not sure I can do the merge before
>> our Minathon ?
>> I'll let you know.
>>
>> Jeff
>>
>>
>> On Thu, May 30, 2013 at 9:16 PM, Julien Vermillard <jv...@gmail.com>wrote:
>>
>>> So with UDP server and client added and a not that bad test coverage
>>> (in both performance and functional test). we are not far.
>>> We wait for SSL before M1 ?
>>>
>>
>>
>>
>> --
>> Jeff MAURY
>>
>>
>> "Legacy code" often differs from its suggested alternative by actually
>> working and scaling.
>> - Bjarne Stroustrup
>>
>> http://www.jeffmaury.com
>> http://riadiscuss.jeffmaury.com
>> http://www.twitter.com/jeffmaury
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
We so we are good no ?
I'll do a code/javadoc review and I think we can trigger the vote.
Julien
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/
On Fri, May 31, 2013 at 2:01 PM, Jeff MAURY <je...@jeffmaury.com> wrote:
> +1 for integrating SSL into M1.
> As i'm busy working for Eclipsecon, I'm not sure I can do the merge before
> our Minathon ?
> I'll let you know.
>
> Jeff
>
>
> On Thu, May 30, 2013 at 9:16 PM, Julien Vermillard <jv...@gmail.com>wrote:
>
>> So with UDP server and client added and a not that bad test coverage
>> (in both performance and functional test). we are not far.
>> We wait for SSL before M1 ?
>>
>
>
>
> --
> Jeff MAURY
>
>
> "Legacy code" often differs from its suggested alternative by actually
> working and scaling.
> - Bjarne Stroustrup
>
> http://www.jeffmaury.com
> http://riadiscuss.jeffmaury.com
> http://www.twitter.com/jeffmaury
Re: [MINA3] M1?
Posted by Jeff MAURY <je...@jeffmaury.com>.
+1 for integrating SSL into M1.
As i'm busy working for Eclipsecon, I'm not sure I can do the merge before
our Minathon ?
I'll let you know.
Jeff
On Thu, May 30, 2013 at 9:16 PM, Julien Vermillard <jv...@gmail.com>wrote:
> So with UDP server and client added and a not that bad test coverage
> (in both performance and functional test). we are not far.
> We wait for SSL before M1 ?
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
So with UDP server and client added and a not that bad test coverage
(in both performance and functional test). we are not far.
We wait for SSL before M1 ?
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/21/13 11:01 AM, Jeff MAURY a écrit :
> I think that Netty 4 is not yet releases (4.0.0.CR3 and not 4.0.0.Final).
> So I think we should keep Netty3 tests.
We should keep them, but add some Netty4 tests.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Jeff MAURY <je...@jeffmaury.com>.
I think that Netty 4 is not yet releases (4.0.0.CR3 and not 4.0.0.Final).
So I think we should keep Netty3 tests.
Jeff
On Mon, May 20, 2013 at 8:34 AM, Julien Vermillard <jv...@gmail.com>wrote:
> Would be great if you upgrade the netty test to v4 !
> By the way, should we keep the netty 3 tests ? is it "faster" in some case
> ?
>
> Julien
>
> On Sun, May 19, 2013 at 9:15 PM, Norman Maurer
> <no...@googlemail.com> wrote:
> > Alright... Let me see if I find the time over the next days.
> >
> > Am 19.05.2013 um 18:48 schrieb Emmanuel Lécharny <el...@gmail.com>:
> >
> >> Le 5/19/13 6:27 PM, Norman Maurer a écrit :
> >>> If you explain me how to do I can even take care ;)
> >>
> >> This is pretty simple :)
> >>
> >> The code is in
> http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/
> >>
> >> we have benchmarks for Netty3 and MINA3, the idea is to add a
> >> combinaison for Netty4.
> >>
> >> The type of clients and servers are defined in the BenchmarkFactory
> >> class. You have to add a Netty4_udp and Netty4_tcp. Then the
> >> BenchmarkClientFactory and BenchmarkServerFactory class have to be
> >> augmented to handle the Netty4 clients and server for TCP and UDP. Those
> >> are pretty straghtforward modifications.
> >>
> >> Then you have to write the real flesh : in the nio/tcp and nio/udp
> >> packages, you have to add the classes to create the Netty4 client and
> >> server for UDP and TCP. This is where the initialization is done.
> >>
> >> Last, not least, the tests themselves are in some new classes names
> >>
> [Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest.
> >> Those new classes just have to reference the correct type defined in the
> >> BenchmarkFactory.
> >>
> >> Thanks a lot of the help !
> >>
> >> --
> >> Regards,
> >> Cordialement,
> >> Emmanuel Lécharny
> >> www.iktek.com
> >>
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
Would be great if you upgrade the netty test to v4 !
By the way, should we keep the netty 3 tests ? is it "faster" in some case ?
Julien
On Sun, May 19, 2013 at 9:15 PM, Norman Maurer
<no...@googlemail.com> wrote:
> Alright... Let me see if I find the time over the next days.
>
> Am 19.05.2013 um 18:48 schrieb Emmanuel Lécharny <el...@gmail.com>:
>
>> Le 5/19/13 6:27 PM, Norman Maurer a écrit :
>>> If you explain me how to do I can even take care ;)
>>
>> This is pretty simple :)
>>
>> The code is in http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/
>>
>> we have benchmarks for Netty3 and MINA3, the idea is to add a
>> combinaison for Netty4.
>>
>> The type of clients and servers are defined in the BenchmarkFactory
>> class. You have to add a Netty4_udp and Netty4_tcp. Then the
>> BenchmarkClientFactory and BenchmarkServerFactory class have to be
>> augmented to handle the Netty4 clients and server for TCP and UDP. Those
>> are pretty straghtforward modifications.
>>
>> Then you have to write the real flesh : in the nio/tcp and nio/udp
>> packages, you have to add the classes to create the Netty4 client and
>> server for UDP and TCP. This is where the initialization is done.
>>
>> Last, not least, the tests themselves are in some new classes names
>> [Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest.
>> Those new classes just have to reference the correct type defined in the
>> BenchmarkFactory.
>>
>> Thanks a lot of the help !
>>
>> --
>> Regards,
>> Cordialement,
>> Emmanuel Lécharny
>> www.iktek.com
>>
Re: [MINA3] M1?
Posted by Norman Maurer <no...@googlemail.com>.
Alright... Let me see if I find the time over the next days.
Am 19.05.2013 um 18:48 schrieb Emmanuel Lécharny <el...@gmail.com>:
> Le 5/19/13 6:27 PM, Norman Maurer a écrit :
>> If you explain me how to do I can even take care ;)
>
> This is pretty simple :)
>
> The code is in http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/
>
> we have benchmarks for Netty3 and MINA3, the idea is to add a
> combinaison for Netty4.
>
> The type of clients and servers are defined in the BenchmarkFactory
> class. You have to add a Netty4_udp and Netty4_tcp. Then the
> BenchmarkClientFactory and BenchmarkServerFactory class have to be
> augmented to handle the Netty4 clients and server for TCP and UDP. Those
> are pretty straghtforward modifications.
>
> Then you have to write the real flesh : in the nio/tcp and nio/udp
> packages, you have to add the classes to create the Netty4 client and
> server for UDP and TCP. This is where the initialization is done.
>
> Last, not least, the tests themselves are in some new classes names
> [Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest.
> Those new classes just have to reference the correct type defined in the
> BenchmarkFactory.
>
> Thanks a lot of the help !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/19/13 6:27 PM, Norman Maurer a écrit :
> If you explain me how to do I can even take care ;)
This is pretty simple :)
The code is in http://svn.apache.org/repos/asf/mina/mina/trunk/benchmarks/
we have benchmarks for Netty3 and MINA3, the idea is to add a
combinaison for Netty4.
The type of clients and servers are defined in the BenchmarkFactory
class. You have to add a Netty4_udp and Netty4_tcp. Then the
BenchmarkClientFactory and BenchmarkServerFactory class have to be
augmented to handle the Netty4 clients and server for TCP and UDP. Those
are pretty straghtforward modifications.
Then you have to write the real flesh : in the nio/tcp and nio/udp
packages, you have to add the classes to create the Netty4 client and
server for UDP and TCP. This is where the initialization is done.
Last, not least, the tests themselves are in some new classes names
[Netty4|Netty3|Mina3]ClientVs[Netty4|Netty3|Mina3]Server[Tcp|Udp]BenchmarkBinaryTest.
Those new classes just have to reference the correct type defined in the
BenchmarkFactory.
Thanks a lot of the help !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Norman Maurer <no...@googlemail.com>.
If you explain me how to do I can even take care ;)
Bye,
Norman
Am 19.05.2013 um 18:20 schrieb Emmanuel Lécharny <el...@gmail.com>:
> Le 5/19/13 5:36 PM, Julien Vermillard a écrit :
>> I just commited the NIO UDP client.
>> I'll focus on UDP tests (both client and server).
>>
>> Would be nice if someone update the benchmarks for replacing the Netty
>> client by the new one.
>
> You mean Netty 4 ?
>
> I con do that.
>>
>> And then I think we can fire a vote for a first milestone.
>
> DO we consider SSL handling ok ? Jeff ?
>
>>
>> I think I'll try to produce a old blocking IO based UDP server For see how
>> it performs and if the inner code of MINA can easily accept blocking
>> transports.
>
> We have to deliver a BioUdpServer and a BioTcpServer anyway. (and the
> client too).
>
> That would be a great addition to a first milestone, but if it's not
> ready, we can add it for M2.
>
> Thanks Julien !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/19/13 5:36 PM, Julien Vermillard a écrit :
> I just commited the NIO UDP client.
> I'll focus on UDP tests (both client and server).
>
> Would be nice if someone update the benchmarks for replacing the Netty
> client by the new one.
You mean Netty 4 ?
I con do that.
>
> And then I think we can fire a vote for a first milestone.
DO we consider SSL handling ok ? Jeff ?
>
> I think I'll try to produce a old blocking IO based UDP server For see how
> it performs and if the inner code of MINA can easily accept blocking
> transports.
We have to deliver a BioUdpServer and a BioTcpServer anyway. (and the
client too).
That would be a great addition to a first milestone, but if it's not
ready, we can add it for M2.
Thanks Julien !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
I just commited the NIO UDP client.
I'll focus on UDP tests (both client and server).
Would be nice if someone update the benchmarks for replacing the Netty
client by the new one.
And then I think we can fire a vote for a first milestone.
I think I'll try to produce a old blocking IO based UDP server For see how
it performs and if the inner code of MINA can easily accept blocking
transports.
Le 18 avr. 2013 14:40, "Emmanuel Lécharny" <el...@gmail.com> a écrit :
> Le 4/18/13 2:24 PM, Julien Vermillard a écrit :
> > Hi,
> >
> > On Thu, Apr 18, 2013 at 1:04 PM, Emmanuel Lécharny <elecharny@gmail.com
> >wrote:
> >
> >> Le 4/18/13 11:04 AM, Julien Vermillard a écrit :
> >>> So a M1 could be : a UDP client and some more test ?
> >> I would not phrase it this way. We don't need "some more tests", we do
> >> need tests that validate what we have. WRT SSL, we need more than tests,
> >> we need tests that helps demonstrating that we have a working SSL
> >> implementation. So far, Jean-François added some test that prove it's
> >> broken...
> >>
> > So we need more test, on the part not covered.
> That's it
>
> > I don't get your message
> > here...
> Just wanted to stress out that we don't need more test on everything.
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/18/13 2:24 PM, Julien Vermillard a écrit :
> Hi,
>
> On Thu, Apr 18, 2013 at 1:04 PM, Emmanuel Lécharny <el...@gmail.com>wrote:
>
>> Le 4/18/13 11:04 AM, Julien Vermillard a écrit :
>>> So a M1 could be : a UDP client and some more test ?
>> I would not phrase it this way. We don't need "some more tests", we do
>> need tests that validate what we have. WRT SSL, we need more than tests,
>> we need tests that helps demonstrating that we have a working SSL
>> implementation. So far, Jean-François added some test that prove it's
>> broken...
>>
> So we need more test, on the part not covered.
That's it
> I don't get your message
> here...
Just wanted to stress out that we don't need more test on everything.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
Hi,
On Thu, Apr 18, 2013 at 1:04 PM, Emmanuel Lécharny <el...@gmail.com>wrote:
> Le 4/18/13 11:04 AM, Julien Vermillard a écrit :
> > So a M1 could be : a UDP client and some more test ?
>
> I would not phrase it this way. We don't need "some more tests", we do
> need tests that validate what we have. WRT SSL, we need more than tests,
> we need tests that helps demonstrating that we have a working SSL
> implementation. So far, Jean-François added some test that prove it's
> broken...
>
So we need more test, on the part not covered. I don't get your message
here...
>
> My current state of mind is that we need a M1 with a very limited set of
> features, just to have it in maven repo, as a base for the next
> iterations. And the minimal set of features would be full TCP and UDP
> support on both sides (client and server).
>
> Of course, it will be a milstone, so don't have any expectation on the
> API stability or whatever...
>
> My 2cts...
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/18/13 11:04 AM, Julien Vermillard a écrit :
> So a M1 could be : a UDP client and some more test ?
I would not phrase it this way. We don't need "some more tests", we do
need tests that validate what we have. WRT SSL, we need more than tests,
we need tests that helps demonstrating that we have a working SSL
implementation. So far, Jean-François added some test that prove it's
broken...
My current state of mind is that we need a M1 with a very limited set of
features, just to have it in maven repo, as a base for the next
iterations. And the minimal set of features would be full TCP and UDP
support on both sides (client and server).
Of course, it will be a milstone, so don't have any expectation on the
API stability or whatever...
My 2cts...
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Julien Vermillard <jv...@gmail.com>.
So a M1 could be : a UDP client and some more test ?
On Thu, Apr 18, 2013 at 10:38 AM, Emmanuel Lécharny <el...@gmail.com>wrote:
> Le 4/18/13 10:32 AM, Jeff MAURY a écrit :
> > As I'm new to this process, what is the quality level you expect in M*
> > releases. I've seen lots of problems in the SSL part, I don't think SSL
> is
> > working at all, so should we fix it before or after ?
> Yes, we should fix it before M1. I think we have made some progress last
> week, but we need better tests and most certainly some code review. Lack
> of time on my side this week...
>
> We can also consider that SSL is for M2 at this point. Milestone are
> just a way to make baby steps toward the first RC.
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
Re: [MINA3] M1?
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 4/18/13 10:32 AM, Jeff MAURY a écrit :
> As I'm new to this process, what is the quality level you expect in M*
> releases. I've seen lots of problems in the SSL part, I don't think SSL is
> working at all, so should we fix it before or after ?
Yes, we should fix it before M1. I think we have made some progress last
week, but we need better tests and most certainly some code review. Lack
of time on my side this week...
We can also consider that SSL is for M2 at this point. Milestone are
just a way to make baby steps toward the first RC.
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: [MINA3] M1?
Posted by Jeff MAURY <je...@jeffmaury.com>.
As I'm new to this process, what is the quality level you expect in M*
releases. I've seen lots of problems in the SSL part, I don't think SSL is
working at all, so should we fix it before or after ?
Regards
Jeff
On Thu, Apr 18, 2013 at 10:19 AM, Julien Vermillard
<jv...@gmail.com>wrote:
> Hi,
>
> Since udp support landed in mina 3, what would be be the missing bits
> before starting a M1 vote ?
> Julien
>
--
Jeff MAURY
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
- Bjarne Stroustrup
http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury