You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/02 04:53:21 UTC
[GitHub] [dolphinscheduler] kezhenxu94 opened a new pull request #6087: Add alert server into standalone-server as well and some minor polish
kezhenxu94 opened a new pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087
## Purpose of the pull request
Add alert server into standalone server as well, now the standalone server should be feature-complete.
Make `AlertServer#start` non-blocking, it was blocking and the codes after `AlertServer#start` won't be executed, causing unexpected problems, now `AlertServer#start` is background thread and the shutdown hook can be registered successfully.
## Brief change log
- Add alert server to standalone server.
- Fix `.asf.yaml` invalid character.
- Some minor polish in alert server.
- Remove pointless comments.
- Reformat h2 `.sql` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-917438143
You're right, it work fine after I rebuild! THX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-917007184
It seem standalone server could not work correct, it work fine days ago before I rebase to dev, did I miss something or some configure? @kezhenxu94
```log
Exception in thread "Standalone-Server" java.lang.RuntimeException: Load Alert Plugin Failed !
at org.apache.dolphinscheduler.alert.AlertServer.initPlugin(AlertServer.java:100)
at org.apache.dolphinscheduler.alert.AlertServer.start(AlertServer.java:119)
at org.apache.dolphinscheduler.server.StandaloneServer.startAlertServer(StandaloneServer.java:80)
at org.apache.dolphinscheduler.server.StandaloneServer.main(StandaloneServer.java:62)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 29999
at org.objectweb.asm.ClassReader.<init>(Unknown Source)
at org.objectweb.asm.ClassReader.<init>(Unknown Source)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.readClass(DolphinPluginDiscovery.java:125)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.classInterfaces(DolphinPluginDiscovery.java:110)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.lambda$discoverPluginsFromArtifact$0(DolphinPluginDiscovery.java:77)
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.discoverPluginsFromArtifact(DolphinPluginDiscovery.java:78)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.buildPluginClassLoaderFromPom(DolphinPluginLoader.java:138)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.buildPluginClassLoader(DolphinPluginLoader.java:123)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.loadPlugin(DolphinPluginLoader.java:99)
at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.loadPlugins(DolphinPluginLoader.java:92)
at org.apache.dolphinscheduler.alert.AlertServer.initPlugin(AlertServer.java:98)
... 3 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs merged pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-911183767
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6087](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ecfd89) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/b49f5b0389793a08656b36d61990eb7ac706070c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b49f5b0) will **decrease** coverage by `0.01%`.
> The diff coverage is `61.90%`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #6087 +/- ##
============================================
- Coverage 46.32% 46.31% -0.02%
+ Complexity 3736 3730 -6
============================================
Files 609 608 -1
Lines 25075 25062 -13
Branches 2867 2866 -1
============================================
- Hits 11616 11607 -9
+ Misses 12319 12314 -5
- Partials 1140 1141 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...heduler/alert/processor/AlertRequestProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9wcm9jZXNzb3IvQWxlcnRSZXF1ZXN0UHJvY2Vzc29yLmphdmE=) | `92.85% <ø> (ø)` | |
| [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `90.90% <ø> (ø)` | |
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `66.10% <57.89%> (+6.77%)` | :arrow_up: |
| [...olphinscheduler/plugin/alert/email/MailSender.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC1wbHVnaW4vZG9scGhpbnNjaGVkdWxlci1hbGVydC1lbWFpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9wbHVnaW4vYWxlcnQvZW1haWwvTWFpbFNlbmRlci5qYXZh) | `51.38% <100.00%> (ø)` | |
| [...phinscheduler/alert/plugin/AlertPluginManager.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9wbHVnaW4vQWxlcnRQbHVnaW5NYW5hZ2VyLmphdmE=) | `80.55% <100.00%> (ø)` | |
| [...ache/dolphinscheduler/server/log/LoggerServer.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2xvZy9Mb2dnZXJTZXJ2ZXIuamF2YQ==) | `78.26% <0.00%> (-8.70%)` | :arrow_down: |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.35% <0.00%> (-1.70%)` | :arrow_down: |
| [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `15.96% <0.00%> (-0.37%)` | :arrow_down: |
| [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `68.05% <0.00%> (+4.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b49f5b0...1ecfd89](https://codecov.io/gh/apache/dolphinscheduler/pull/6087?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-917009739
> It seem standalone server could not work correct, it work fine days ago before I rebase to dev, did I miss something or some configure? @kezhenxu94
>
>
>
> ```log
>
> Exception in thread "Standalone-Server" java.lang.RuntimeException: Load Alert Plugin Failed !
>
> at org.apache.dolphinscheduler.alert.AlertServer.initPlugin(AlertServer.java:100)
>
> at org.apache.dolphinscheduler.alert.AlertServer.start(AlertServer.java:119)
>
> at org.apache.dolphinscheduler.server.StandaloneServer.startAlertServer(StandaloneServer.java:80)
>
> at org.apache.dolphinscheduler.server.StandaloneServer.main(StandaloneServer.java:62)
>
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 29999
>
> at org.objectweb.asm.ClassReader.<init>(Unknown Source)
>
> at org.objectweb.asm.ClassReader.<init>(Unknown Source)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.readClass(DolphinPluginDiscovery.java:125)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.classInterfaces(DolphinPluginDiscovery.java:110)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.lambda$discoverPluginsFromArtifact$0(DolphinPluginDiscovery.java:77)
>
> at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
>
> at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
>
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
>
> at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>
> at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
>
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginDiscovery.discoverPluginsFromArtifact(DolphinPluginDiscovery.java:78)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.buildPluginClassLoaderFromPom(DolphinPluginLoader.java:138)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.buildPluginClassLoader(DolphinPluginLoader.java:123)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.loadPlugin(DolphinPluginLoader.java:99)
>
> at org.apache.dolphinscheduler.spi.plugin.DolphinPluginLoader.loadPlugins(DolphinPluginLoader.java:92)
>
> at org.apache.dolphinscheduler.alert.AlertServer.initPlugin(AlertServer.java:98)
>
> ... 3 more
>
> ```
I suspect you are using old versions compiled classes of the previous plugin and after rebased the classes are not correct. Maybe try to rebuild the plugins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-911188142
SonarCloud Quality Gate failed. 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6087&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6087&metric=new_coverage&view=list) [27.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6087&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6087&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6087&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-917036049
There is another situation:
using plugin.binding usually requires you to manually compile the plugin, you can try mvn complie first and then run StandaloneServer again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs removed a comment on pull request #6087: Add alert server into standalone-server as well and some minor polish
Posted by GitBox <gi...@apache.org>.
CalvinKirs removed a comment on pull request #6087:
URL: https://github.com/apache/dolphinscheduler/pull/6087#issuecomment-917036049
There is another situation:
using plugin.binding usually requires you to manually compile the plugin, you can try mvn complie first and then run StandaloneServer again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org