You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 16:40:01 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13195: Add integration tests for Apache Pinot
mik-laj opened a new pull request #13195:
URL: https://github.com/apache/airflow/pull/13195
I wanted to update the [pinotdb](https://pypi.org/project/pinotdb/) library, so I added one integration test to be able to easily check this integration.
Part of: https://github.com/apache/airflow/issues/12120
Latest supported version for Airflow 2.0: 0.1.1 (2 years ago)
Latest supported version for Airflow 1.10: 0.1.1 (2 years ago)
Latest version: 0.3.3 (5 months ago)
Diff between releases date of latest version and latest supported version: 2 years
```
root@4cc53fe49ba8:/opt/airflow# pytest tests/providers/apache/pinot/hooks/test_pinot.py -k Integrat -s
=========================================================================================== test session starts ============================================================================================
platform linux -- Python 3.6.12, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: forked-1.3.0, timeouts-1.2.1, cov-2.10.1, xdist-2.1.0, instafail-0.4.2, flaky-3.7.0, requests-mock-1.8.0, rerunfailures-9.1.1, celery-4.4.7
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 13 items / 12 deselected / 1 selected
tests/providers/apache/pinot/hooks/test_pinot.py::TestPinotDbApiHookIntegration::test_should_return_records ========================= AIRFLOW ==========================
Home of the user: /root
Airflow home /root/airflow
Skipping initializing of the DB as it was initialized already.
You can re-initialize the database by adding --with-db-init flag when running tests.
[2020-12-20 16:19:55,293] {base.py:74} INFO - Using connection to: id: pinot_broker_default. Host: pinot, Port: 8000, Schema: , Login: None, Password: None, extra: None
[2020-12-20 16:19:55,294] {pinot.py:275} INFO - Get the connection to pinot broker on pinot
PASSED
===================================================================================== 1 passed, 12 deselected in 1.78s =====================================================================================
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751265539
We have next issue - mock<4.0.3 is not compatible with latest moto. See: https://github.com/spulec/moto/issues/3535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751859705
I pinned `pyjwt` to `<2`. https://github.com/apache/airflow/blob/6063583cb2f981880f0a75a97118b96ae401d9dd/setup.py#L396-L398
It helped until the new change https://github.com/apache/airflow/commit/82fa048c128b698a28d69d92e0c01d9b3953d883 was merged. I have a feeling that this is not a problem with my change now, but it is a more general problem in CI setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749695002
[The Workflow run](https://github.com/apache/airflow/actions/runs/438514792) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#discussion_r547472644
##########
File path: setup.py
##########
@@ -181,7 +181,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'atlasclient>=0.1.2',
]
azure = [
- 'azure-batch>=8.0.0',
+ 'azure-batch>=8.0.0,<10.0.0',
Review comment:
You can likely remove that limitation as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751559284
@potiuk Finally green after pinning some additional libraries. Can you look at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749105740
[The Workflow run](https://github.com/apache/airflow/actions/runs/436252286) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#discussion_r547516470
##########
File path: setup.py
##########
@@ -181,7 +181,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'atlasclient>=0.1.2',
]
azure = [
- 'azure-batch>=8.0.0',
+ 'azure-batch>=8.0.0,<10.0.0',
Review comment:
I had to add another restriction. [pyjwt](https://pypi.org/project/PyJWT/#history) was updated a few hours ago and is causing the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749259102
[The Workflow run](https://github.com/apache/airflow/actions/runs/436882633) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749268123
[The Workflow run](https://github.com/apache/airflow/actions/runs/436942003) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751877183
[The Workflow run](https://github.com/apache/airflow/actions/runs/449602598) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13195:
URL: https://github.com/apache/airflow/pull/13195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751995140
@potiuk Looks like all problems are fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751858849
> @potiuk Rebased and CI are sad. Can you help me with it?
Sure. Can you read the instructions below the error here:
https://github.com/apache/airflow/pull/13195/checks?check_run_id=1618826928
msal 1.8.0 has requirement PyJWT[crypto]<2,>=1.0.0, but you have pyjwt 2.0.0.
flask-jwt-extended 3.25.0 has requirement PyJWT<2.0,>=1.6.4, but you have pyjwt 2.0.0.
ERROR: ^^^ Some dependencies are conflicting. See instructions below on how to deal with it.
There are some instructions what to do, can you please follow it? I have some idea what to do but I would love to know if you reach the same conclusions and whether we can update the instructions to be cleaner? My goal is that anyone should be able to fix this kind of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749514803
[The Workflow run](https://github.com/apache/airflow/actions/runs/437963167) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749253469
[The Workflow run](https://github.com/apache/airflow/actions/runs/436852121) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749514491
[The Workflow run](https://github.com/apache/airflow/actions/runs/438007645) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-748672686
[The Workflow run](https://github.com/apache/airflow/actions/runs/434454163) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749486093
[The Workflow run](https://github.com/apache/airflow/actions/runs/437841312) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-749538709
[The Workflow run](https://github.com/apache/airflow/actions/runs/438110436) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#discussion_r549650875
##########
File path: setup.cfg
##########
@@ -113,11 +113,16 @@ install_requires =
pendulum~=2.0
pep562~=1.0;python_version<"3.7"
psutil>=4.2.0, <6.0.0
+ # snowflake-connector-python don't support newer version
+ # https://github.com/snowflakedb/snowflake-connector-python/blob/v2.3.6/setup.py#L201
+ pyOpenSSL<20.0.0
pygments>=2.0.1, <3.0
+ # snowflake-connector-python, flask-jwt-extended, msal are not compatible with newest version.
+ pyjwt<2
python-daemon>=2.1.1
python-dateutil>=2.3, <3
python-nvd3~=0.15.0
- python-slugify>=3.0.0,<5.0
+ python-slugify>=3.0.0,<5.
Review comment:
```suggestion
python-slugify>=3.0.0,<5.0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13195: Add integration tests for Apache Pinot
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13195:
URL: https://github.com/apache/airflow/pull/13195#issuecomment-751856946
@potiuk Rebased and CI are sad. Can you help me with it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org