You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/24 19:51:00 UTC

[jira] [Commented] (IGNITE-8459) Searching checkpoint history for WAL rebalance is broken

    [ https://issues.apache.org/jira/browse/IGNITE-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489676#comment-16489676 ] 

ASF GitHub Bot commented on IGNITE-8459:
----------------------------------------

GitHub user Jokser opened a pull request:

    https://github.com/apache/ignite/pull/4065

    IGNITE-8459 Do first checkpoint after all partitions have been initialized

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-8459

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/4065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4065
    
----
commit df3fb2a24d4d43771094e56fea6680f23e3790e6
Author: Pavel Kovalenko <jo...@...>
Date:   2018-05-18T09:37:13Z

    IGNITE-8459 WIP

commit 54e88d22bfd4c0b61593b4a8f0d5c319288593b7
Author: Pavel Kovalenko <jo...@...>
Date:   2018-05-18T16:22:01Z

    IGNITE-8459 WIP

commit e8aeeea9d6c30df2ee03bfada3a8a399cfef7b6b
Author: Pavel Kovalenko <jo...@...>
Date:   2018-05-21T12:42:33Z

    IGNITE-8459 WIP

commit 7d58eb9e3c3fa2358c7937ce3f73715d850a33f1
Author: Pavel Kovalenko <jo...@...>
Date:   2018-05-24T19:46:24Z

    IGNITE-8459 Rework.

commit bd8ef85034bbf7c03d6c8b40b36fa4398a3b23ca
Author: Pavel Kovalenko <jo...@...>
Date:   2018-05-24T19:50:11Z

    IGNITE-8459 Remove trash.

----


> Searching checkpoint history for WAL rebalance is broken
> --------------------------------------------------------
>
>                 Key: IGNITE-8459
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8459
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.5
>            Reporter: Pavel Kovalenko
>            Assignee: Pavel Kovalenko
>            Priority: Critical
>             Fix For: 2.6
>
>
> Currently the mechanism to search available checkpoint records in WAL to have history for WAL rebalance is broken. It means that WAL (Historical) rebalance will never find history for rebalance and full rebalance will be always used.
> This mechanism was broken in https://github.com/apache/ignite/commit/ec04cd174ed5476fba83e8682214390736321b37 by unclear reasons.
> If we swap the following two code blocks (database().beforeExchange() and exchCtx if block):
> {noformat}
>         /* It is necessary to run database callback before all topology callbacks.
>            In case of persistent store is enabled we first restore partitions presented on disk.
>            We need to guarantee that there are no partition state changes logged to WAL before this callback
>            to make sure that we correctly restored last actual states. */
>         cctx.database().beforeExchange(this);
>         if (!exchCtx.mergeExchanges()) {
>             for (CacheGroupContext grp : cctx.cache().cacheGroups()) {
>                 if (grp.isLocal() || cacheGroupStopping(grp.groupId()))
>                     continue;
>                 // It is possible affinity is not initialized yet if node joins to cluster.
>                 if (grp.affinity().lastVersion().topologyVersion() > 0)
>                     grp.topology().beforeExchange(this, !centralizedAff && !forceAffReassignment, false);
>             }
>         }
> {noformat}
> the searching mechanism will start to work correctly. Currently it's unclear why it's happened.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)