You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Youwei Wang (Code Review)" <ge...@cloudera.org> on 2016/09/01 08:48:31 UTC
[Impala-CR](cdh5-trunk) Impala-4058: unaligned memory access issue in SIMDed byteswap.
Youwei Wang has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4198
Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap.
......................................................................
Impala-4058: unaligned memory access issue in SIMDed byteswap.
Substitute the direct memory assignments using _mm_loadu_si128/_mm_storeu_si128
to prevent the compiler from generating aligned memory access instructions which
may cause crash.
Add new test cases in the expr-test.cc and re-run the bswap-benchmark.
No performance regression observed.
Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
---
M be/src/exprs/expr-test.cc
M be/src/util/bit-util.cc
2 files changed, 24 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/98/4198/1
--
To view, visit http://gerrit.cloudera.org:8080/4198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <yo...@intel.com>
[Impala-CR](cdh5-trunk) Impala-4058: unaligned memory access issue in SIMDed byteswap.
Posted by "Youwei Wang (Code Review)" <ge...@cloudera.org>.
Youwei Wang has abandoned this change.
Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap.
......................................................................
Abandoned
Switched to Apache-hosted git, new link: https://gerrit.cloudera.org/#/c/4204/.
This change is abandoned. Sorry for any inconvenience if caused.
--
To view, visit http://gerrit.cloudera.org:8080/4198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <yo...@intel.com>
[Impala-CR](cdh5-trunk) Impala-4058: unaligned memory access issue in SIMDed byteswap.
Posted by "Youwei Wang (Code Review)" <ge...@cloudera.org>.
Youwei Wang has uploaded a new patch set (#2).
Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap.
......................................................................
Impala-4058: unaligned memory access issue in SIMDed byteswap.
Substitute the direct memory assignments using _mm_loadu_si128/_mm_storeu_si128
to prevent the compiler from generating aligned memory access instructions which
may cause crash.
Add new test cases in the expr-test.cc and re-run the bswap-benchmark.
No performance regression observed.
Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
---
M be/src/benchmarks/bswap-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/util/bit-util.cc
3 files changed, 38 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/98/4198/2
--
To view, visit http://gerrit.cloudera.org:8080/4198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <yo...@intel.com>