You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/11/06 16:14:01 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3766: Support real user for KyuubiSession

pan3793 commented on code in PR #3766:
URL: https://github.com/apache/incubator-kyuubi/pull/3766#discussion_r1014856183


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -136,13 +136,13 @@ abstract class TFrontendService(name: String)
     }
   }
 
-  protected def getUserName(req: TOpenSessionReq): String = {
+  protected def getUserName(req: TOpenSessionReq): (String, String) = {

Review Comment:
   please add doc to explain the return values



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org