You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by do...@apache.org on 2001/12/16 05:34:14 UTC

cvs commit: jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional Cab.java

donaldp     01/12/15 20:34:14

  Modified:    proposal/myrmidon/src/main/org/apache/tools/ant
                        BuildEvent.java Task.java
               proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs
                        Get.java Rmic.java
               proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional
                        Cab.java
  Log:
  No need for tasks to know which target they are in ... or even if they are in a target.
  
  Revision  Changes    Path
  1.3       +0 -1      jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/BuildEvent.java
  
  Index: BuildEvent.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/BuildEvent.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- BuildEvent.java	2001/12/16 01:01:19	1.2
  +++ BuildEvent.java	2001/12/16 04:34:14	1.3
  @@ -53,7 +53,6 @@
       {
           super( task );
           this.project = task.getProject();
  -        this.target = task.getOwningTarget();
           this.task = task;
       }
   
  
  
  
  1.7       +0 -20     jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/Task.java
  
  Index: Task.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/Task.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Task.java	2001/12/16 04:26:05	1.6
  +++ Task.java	2001/12/16 04:34:14	1.7
  @@ -13,7 +13,6 @@
       extends ProjectComponent
       implements org.apache.myrmidon.api.Task
   {
  -    protected Target target;
       protected String description;
       protected String taskType;
   
  @@ -28,30 +27,11 @@
           description = desc;
       }
   
  -    /**
  -     * Sets the target object of this task.
  -     *
  -     * @param target Target in whose scope this task belongs.
  -     */
  -    public void setOwningTarget( Target target )
  -    {
  -        this.target = target;
  -    }
  -
       public String getDescription()
       {
           return description;
       }
   
  -    /**
  -     * Get the Target to which this task belongs
  -     *
  -     * @return the task's target.
  -     */
  -    public Target getOwningTarget()
  -    {
  -        return target;
  -    }
       /**
        * Perform this task
        */
  
  
  
  1.6       +0 -1      jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Get.java
  
  Index: Get.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Get.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- Get.java	2001/12/16 04:12:39	1.5
  +++ Get.java	2001/12/16 04:34:14	1.6
  @@ -303,7 +303,6 @@
           if( project.getJavaVersion() != Project.JAVA_1_1 )
           {
               Touch touch = (Touch)project.createTask( "touch" );
  -            touch.setOwningTarget( target );
               touch.setFile( file );
               touch.setMillis( timemillis );
               touch.touch();
  
  
  
  1.8       +0 -1      jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java
  
  Index: Rmic.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/Rmic.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- Rmic.java	2001/12/16 04:12:39	1.7
  +++ Rmic.java	2001/12/16 04:34:14	1.8
  @@ -691,6 +691,5 @@
               }
           }
       }
  -
   }
   
  
  
  
  1.4       +1 -2      jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java
  
  Index: Cab.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/proposal/myrmidon/src/main/org/apache/tools/ant/taskdefs/optional/Cab.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- Cab.java	2001/12/16 04:12:39	1.3
  +++ Cab.java	2001/12/16 04:34:14	1.4
  @@ -317,8 +317,7 @@
           throws TaskException
       {
           ExecTask exec = (ExecTask)project.createTask( "exec" );
  -        exec.setOwningTarget( this.getOwningTarget() );
  -        exec.setDescription( this.getDescription() );
  +        exec.setDescription( getDescription() );
   
           return exec;
       }
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>