You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/05 13:45:03 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue #509: Update Ballista crate dependencies to include version numbers
andygrove opened a new issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
It is currently not possible to publish the Ballista crates to crates.io from a DataFusioin source release because Ballista has dependencies based on relative path only. For example, the `ballista-client` crate has this dependency:
```toml
datafusion = { path = "../../../datafusion" }
```
We need to update it to include the version number as well:
```toml
datafusion = { path = "../../../datafusion", version = "4.0.0-SNAPSHOT" }
```
We will also need to update the release scripts to update these version numbers as part of the release process.
**Describe the solution you'd like**
- Add `version` to each relative dependency
- Update release scripts to update these versions
- Update documentation
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-856871569
> @alamb , I am curious: do you need datafusion released for iox? I imagine that if you ship it as a binary or docker, you can point to the hash, right?
@jorgecarleitao -- The short answer is no -- we use a [git hash](https://github.com/influxdata/influxdb_iox/blob/main/datafusion/Cargo.toml#L12) in IOx for datafusion
And I don't think we expect anyone to use IOx as a Rust library so I don't think it is likely we would publish it to crates.io -- anything that we think is useful / reusable to others we are trying to contribute back to arrow or datafusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-897213582
@houqp I'm not sure if this issue is still valid or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-855257755
Sounds reasonable to me.
At some point, we should probably figure out a more regular release cadence for DataFusion (right now, my project is just using the head directly from git, but that isn't appropriate for ballista).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
houqp commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-897375078
@andygrove i think you already fixed this one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-856295375
Do you have plans about what you would like Ballista to be? I.e. if we release Ballista as a binary (e.g. in artifactory, or in a docker image), we do not need DataFusion released, as we can point to a github hash. The limitation emerges when placing it in crates.io.
I think that the same applies for other consumers of DataFusion. For example, the Python bindings do not require DataFusion in crate.io: we can build the wheels and ship them to pypi.
Regardless, I agree with @alamb with the cadence, as some consumers may want to ship _libraries_ built on top of datafusion.
@alamb , I am curious: do you need datafusion released for iox? I imagine that if you ship it as a binary or docker, you can point to the hash, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509#issuecomment-855243972
@alamb @jorgecarleitao fyi would be good to get your input on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp closed issue #509: Prepare Ballista crates for publishing
Posted by GitBox <gi...@apache.org>.
houqp closed issue #509:
URL: https://github.com/apache/arrow-datafusion/issues/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org