[jira] Commented: (OFBIZ-2657) 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain

["Hans Bakker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724428#action_12724428 ] 

Hans Bakker commented on OFBIZ-2657:
------------------------------------

After some more investigation i would like to propose the following:

in general.properties define the basic default values of the installed system which will be used when not defined elsewhere.

add:
   baseUrl
   baseSecureUrl
   fromEmailAddress

these values will be slowly introduced where needed and will only be used when not found where they are currently defined.

The first program will be org.ofbiz.common.NotificationServices: setBaseUrl which should use these values when a website is not known and should return the ip numbers as it currently does, when not defined in general.properties.

It is also proposed to change the data for EmailTemplateSetting entity to leave the email address empty and change the sendMailFromTemplateSetting service to use the emailaddress in general properties when it is not defined in EmailTemplateSetting. This will also allow to make the EmailTemplateSetting data 'seed' data (email address not defined anymore here.

when no objections i will implement this proposed change shortly.



> 'from emailadress' & baseurl & baseSecureUrl defined in many places and therefore difficult to maintain
> -------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2657
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2657
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 9.04
>            Reporter: Hans Bakker
>             Fix For: Release Branch 9.04
>
>
> Currently many entities have a 'from emailaddress' defined. That is fine if it is used for an override of a default 'from address' which is however missing.
> the proposal is to add a 'default.from.emailaddress' to the general.properties file and change the seed/demo data to have the 'from emailaddresss' not defined(null). Obviously change the programs that when this field is null it should take it from the general properties file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.