You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 14:58:35 UTC
[GitHub] [arrow] cptjacky opened a new pull request, #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
cptjacky opened a new pull request, #12857:
URL: https://github.com/apache/arrow/pull/12857
When used in its stream version (calling .Read()), the ZSTD decoder makes use of a Goroutine with a channel to receive input. This channel is closed by the decoder's .Close() function, which ends the Goroutine and therefore the collection of its memory by the GC.
Here, we add Close() to the exposed decompressor interface and call its close at the end of the function that uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
URL: https://github.com/apache/arrow/pull/12857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12857:
URL: https://github.com/apache/arrow/pull/12857#issuecomment-1098902936
Benchmark runs are scheduled for baseline = 4b1fc905d0a75306176dfef34d90109804358440 and contender = 667d427d8ef16b1535dc82ce6fe6b7384382231c. 667d427d8ef16b1535dc82ce6fe6b7384382231c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c4b0a3f6319340348eda22b99985f011...4b330c4646294340b0a5c78efd9834c6/)
[Finished :arrow_down:0.54% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cee53239a8e54c4b8052e57cde5a1223...298c955c4164472297fd959281d91891/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4d2a0fd6f21146b6afbe1f51170898b5...e17c27ef726740e0a9cba77b8cab4c61/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/26991af88aaf44a685e6e9ec6b77e9d0...9a895f46c726451993ead9d3190d0b3d/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/501| `667d427d` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/487| `667d427d` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/487| `667d427d` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/497| `667d427d` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/500| `4b1fc905` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/486| `4b1fc905` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/486| `4b1fc905` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/496| `4b1fc905` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12857:
URL: https://github.com/apache/arrow/pull/12857#issuecomment-1095186871
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12857: ARROW-16163: [Go] IPC FileReader leaks memory when used with ZSTD compression
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12857:
URL: https://github.com/apache/arrow/pull/12857#issuecomment-1095186846
https://issues.apache.org/jira/browse/ARROW-16163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org