You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/11/11 18:18:13 UTC
[jira] Created: (HBASE-3227) Edit of log messages before
branching...
Edit of log messages before branching...
----------------------------------------
Key: HBASE-3227
URL: https://issues.apache.org/jira/browse/HBASE-3227
Project: HBase
Issue Type: Improvement
Reporter: stack
Fix For: 0.90.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934996#action_12934996 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: stack@duboce.net
bq. On 2010-11-22 17:29:45, Nicolas wrote:
bq. > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java, line 739
bq. > <http://review.cloudera.org/r/1212/diff/1/?file=17170#file17170line739>
bq. >
bq. > I'd suggest keeping the store name in this debug message since we're considering thread pools for compactions...
Won't the store name be part of the path on the next line when we do sf.toString() where sf is the file we're compacting all into?
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1971
-----------------------------------------------------------
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931096#action_12931096 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jd...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1911
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1212/#comment6126>
I still don't know what this message means :(
- Jean-Daniel
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931095#action_12931095 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/
-----------------------------------------------------------
Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
Summary
-------
Removed redundancy, corrected some of the english in log messages, changed at least one to DEBUG.
This addresses bug hbase-3227.
http://issues.apache.org/jira/browse/hbase-3227
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1033977
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1033977
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1033979
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977
Diff: http://review.cloudera.org/r/1212/diff
Testing
-------
Thanks,
stack
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931097#action_12931097 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jd...@apache.org>
bq. On 2010-11-11 09:31:16, Jean-Daniel Cryans wrote:
bq. >
Ooops meant to say, +1
- Jean-Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1911
-----------------------------------------------------------
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3227) Edit of log messages before
branching...
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3227.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed.
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934688#action_12934688 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: "Nicolas" <ns...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1971
-----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1212/#comment6227>
I'd suggest keeping the store name in this debug message since we're considering thread pools for compactions...
- Nicolas
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3227) Edit of log messages before
branching...
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931106#action_12931106 ]
HBase Review Board commented on HBASE-3227:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1212/#review1913
-----------------------------------------------------------
Ship it!
lgtm
- Jonathan
> Edit of log messages before branching...
> ----------------------------------------
>
> Key: HBASE-3227
> URL: https://issues.apache.org/jira/browse/HBASE-3227
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Fix For: 0.90.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.