[GitHub] [superset] zhaoyongjie commented on pull request #16396: fix: add percent sign in like/ilike clause

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #16396:
URL: https://github.com/apache/superset/pull/16396#issuecomment-920640004


   @junlincc @jinghua-qa 
   Thanks for your input!
   > 1. It looks to me the LIKE operator is not case sensitive
   
   Operator `like` depend on database spec. Some DB treat like is case insensitive. for instance: sqlite. https://sqlite.org/faq.html#q18
   
   > 2. I think this change makes the return in a wider range than the user expected? For example, i am trying to return any name starting with 'Ma' but then the name contains 'ma' all return. And feel choosing operator 'Like' will be different than writing custom SQL using 'Like'
   
   Actually, a wider range is `like` operator meaning instead of `equal` operator. some BI will introduce more operators like `starts with`, `ends with` and `contains` instead of `like`
   
   <img width="499" alt="image" src="https://user-images.githubusercontent.com/2016594/133567004-868c8c06-afca-4045-bf22-2e6a693c8a77.png">
   
   > 3, when input filter value with string only, user need to scroll to the bottom of the list to find the custom input value, which is inconvinient.
   
   need to improve in `Select component project`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org